fix for updating credential #10
Open
+14
−10
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #10 +/- ##
=======================================
Coverage 89.13% 89.13%
=======================================
Files 7 7
Lines 709 709
Branches 89 89
=======================================
Hits 632 632
Misses 77 77 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
|
Memory usage change @ 6f71366
Click for full report table
Click for full report CSV |
per1234
added
type: imperfection
fabik111
force-pushed
the
fix-connected-state
branch
from
6f71366 to
1b50d52
Compare
|
Memory usage change @ 1b50d52
Click for full report table
Click for full report CSV |
pennam
reviewed
May 19, 2025
| _agentsManager->update(); | ||
| bool updatedConfigInprogress = _agentsManager->isConfigInProgress(); |
There was a problem hiding this comment.
Suggested change
| bool updatedConfigInprogress = _agentsManager->isConfigInProgress(); | |
| const bool updatedConfigInprogress = _agentsManager->isConfigInProgress(); |
pennam
reviewed
May 19, 2025
| if (_agentsManager->isConfigInProgress() && !configInprogress) { | ||
| scanNetworkOptions(); | ||
| return NetworkConfiguratorStates::UPDATING_CONFIG; | ||
| if(_configInProgress != updatedConfigInprogress) { |
There was a problem hiding this comment.
Suggested change
| if(_configInProgress != updatedConfigInprogress) { | |
| if (_configInProgress != updatedConfigInprogress) { |
pennam
reviewed
May 19, 2025
| return NetworkConfiguratorStates::UPDATING_CONFIG; | ||
| if(_configInProgress != updatedConfigInprogress) { | ||
| _configInProgress = updatedConfigInprogress; | ||
| if(_configInProgress) { |
There was a problem hiding this comment.
Suggested change
| if(_configInProgress) { | |
| if (_configInProgress) { |
pennam
reviewed
May 19, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR fix the problem:
If the
AgentsManagerClass::update()is called also outside the NetworkConfigurator class and the NetworkConfigurator is in theCONFIGUREDstate, the NetworkConfigurator is no more able to detect when a new peer (Mobile app or FE) is connecting for changing credentials and, consequentially, to move to the stateUPDATING_CONFIGwhen needed