PWM and Lib Servo bug #1614

LamiRene · 2013-10-10T12:45:20Z

Hello,

Excuse my English writing, I use the Google translator to write and to read you. The version of my original French text follows this translation.

After several tests used with a servo motor and two DC motors controlled with an H-bridge with the Arduino library "Servo" standard, 100% PWM pins are inoperative. The PWM mode all pins pass in binary 0 (off) or 1 (On) in two different ways (and I have not researched the reason for the difference).

So, after a command "ServoCommande.attach (...)" All PWM pins are in mode 0 Volt or 5 volts, there are more intermediate values. For the past with instructions values "analogWrite (Motor_1_ENA, Speed);"

0 to 254 = Off and 255 = On.

or

0 to 127 = Off and 128 to 255 = On.

I solve this problem in a very small change in your source code in the file "Servo.h" simply by placing in order crossing order "TIMERx". To be precise, I move "# define _useTimer5" and "_timer5," as follows:

The code:

«
// Say which 16 bit timers can be used and in what order

if defined(AVR_ATmega1280) || defined(AVR_ATmega2560)

define _useTimer5

define _useTimer1

define _useTimer3

define _useTimer4

typedef enum { _timer5, _timer1, _timer3, _timer4, _Nbr_16timers } timer16_Sequence_t ;
»

In the change like this:

«
// Say which 16 bit timers can be used and in what order

if defined(AVR_ATmega1280) || defined(AVR_ATmega2560)

define _useTimer1

define _useTimer3

define _useTimer4

define _useTimer5

typedef enum { _timer1, _timer3, _timer4, _timer5, _Nbr_16timers } timer16_Sequence_t ;
»

I work with Arduino Mega R2 and R3, but I guess the problem is the same with other cards and the order crossing "TIMERx" should also be revised:

from:

«

elif defined(AVR_AT90USB646) || defined(AVR_AT90USB1286)

define _useTimer3

define _useTimer1

typedef enum { _timer3, _timer1, _Nbr_16timers } timer16_Sequence_t ;
»

for :

«

elif defined(AVR_AT90USB646) || defined(AVR_AT90USB1286)

define _useTimer1

define _useTimer3

typedef enum { _timer1, _timer3, _Nbr_16timers } timer16_Sequence_t ;
»

Etc.

With this simple change , I find the use of the normal PWM mode all pins.

So as I spent weeks researching and solve this problem, I guess I 'm not the only one is that you could include this change in your library.

If this is not possible , could you explain why?

I work with operating system GNU/Linux Kubuntu 12.04 64-bits and the Arduino IDE 1.0.5. and I use it for my tested the following products:

1 x Controller Arduino Mega R3:
http://dx.com/p/mega-2560-r3-atmega2560-16au-board-usb-cable-for-arduino-black-blue-215579

1 x Plate experimentation Circuit-Test MB -104 " breadboard ".
http://dx.com/p/solderless-breadboard-white-large-size-121529

1 x box has six 1.5V AA batteries ( 9V):
http://dx.com/p/6-x-aa-batteries-holder-with-dc2-1-power-jack-for-arduino-126413

1 x Power Adapter for Arduino , 9V , 1A, 100cm cable):
http://dx.com/p/arduino-9v-1a-power-adapter-black-2-flat-pin-plug-100cm-cable-126288

1 x Card screen LCD LCD1602 :
http://dx.com/p/1602a-16-x-2-lines-white-character-lcd-module-w-blue-backlight-dc-5v-151978

1 x VS1838B infrared sensor ( TSOP1838 ) :
http://dx.com/p/tsop1838-ir-infrared-37-9khz-receiver-18m-range-2-7-5-5v-135045
http://www.dipmicro.com/store/VS1838B
http://dx.com/s/1838

1 x Mini Remote Control MP3 category
http://dx.com/p/ir-remote-control-diy-kit-for-arduino-1-x-cr2025-136284

1 x ZL-3 Robot Raider Car Kits (2 x 6V DC 77RPM , engine mountings and fittings )
http://dx.com/p/zl-3-robot-raider-car-kits-for-arduino-153030
or :
2 x DC motor N20 ( DC 1.5V ~ 12V) with reduction gear :

1 x Motor Controller L298N (H- Bridge) for two DC motors or one stepper motor :
http://dx.com/p/l298n-stepper-motor-driver-controller-board-module-blue-149662
http://www.datasheetarchive.com/dlmain/Datasheets-5/DSA-95443.pdf
http://www.datasheetarchive.com/dlmain/Datasheets-25/DSA-480678.pdf

2 x Servo Toward Pro MG996R and Accessories:
http://dx.com/p/mg996r-metal-gear-digital-torque-servos-with-gears-and-parts-35763
or
2 x Mini Tower Pro SG90 Servo and Accessories:
http://dx.com/p/towerpro-sg90-mini-plastic-gear-steering-servo-3-pcs-set-187776

1 x module sensor ultrasonic transmitter HR- SC04 .
http://dx.com/p/hc-sr04-ultrasonic-sensor-distance-measuring-module-133696

Sincerely,

René

= = = = = = = = = = = = = = = = = = = = = = = = = = = = = =

Bonjour

Excuser mon anglais écrit, j'utilise le traducteur Google pour vous écrire et pour vous lire. La version de mon texte original en français suit la présente traduction.

Après plusieurs tests d'utilisation avec un servomoteur et deux moteurs à courant continu piloté avec un pont en H, avec la bibliothèque « Servo » standard d'Arduino, 100 % des broches PWM sont inopérants. Le mode PWM de toutes les broches passe en mode binaire 0 (Off) ou 1 (On) de deux manières différentes (et je n'ai pas fouillé le pourquoi de la différence).

Donc, après une commande « ServoCommande.attach (...); » toutes les broches PWM sont en mode 0 Volt ou 5 Volts, il n'y a plus de valeurs intermédiaires. Pour les valeurs passées avec les instructions « analogWrite (Motor_1_ENA, Speed); »

de 0 à 254 = Off et 255 = On.

ou

de 0 à 127 = Off et de 128 à 255 = On.

Je résous ce problème par une très petite modification de votre code source, dans le fichier « Servo.h », simplement en plaçant en ordre croisant l'ordre des "TimerX". Pour être précis, je déplace « #define _useTimer5 » et « _timer5, » de la manière suivante :

Le code :

«
// Say which 16 bit timers can be used and in what order

if defined(AVR_ATmega1280) || defined(AVR_ATmega2560)

define _useTimer5

define _useTimer1

define _useTimer3

define _useTimer4

typedef enum { _timer5, _timer1, _timer3, _timer4, _Nbr_16timers } timer16_Sequence_t ;
»

En le modifient comme ceci :

«
// Say which 16 bit timers can be used and in what order

if defined(AVR_ATmega1280) || defined(AVR_ATmega2560)

define _useTimer1

define _useTimer3

define _useTimer4

define _useTimer5

typedef enum { _timer1, _timer3, _timer4, _timer5, _Nbr_16timers } timer16_Sequence_t ;
»

Je travaille avec des cartes Arduino Mega R2 et R3, mais je présume que le problème est le même avec les autres cartes et que l'ordre croisant des "TimerX" devrait aussi être révisé :

De :

«

elif defined(AVR_AT90USB646) || defined(AVR_AT90USB1286)

define _useTimer3

define _useTimer1

typedef enum { _timer3, _timer1, _Nbr_16timers } timer16_Sequence_t ;
»

Pour :

«

elif defined(AVR_AT90USB646) || defined(AVR_AT90USB1286)

define _useTimer1

define _useTimer3

typedef enum { _timer1, _timer3, _Nbr_16timers } timer16_Sequence_t ;
»

Etc.

Avec ce simple changement, je retrouve l'usage normal du mode PWM sur toutes les broches.

Alors, comme j'ai passé des semaines à chercher et à résoudre ce problème, je présume que je ne suis pas le seul est-ce que vous pourriez inclure cette modification dans votre bibliothèque.

Si cela n'est pas possible, pourriez-vous m'expliquer pourquoi?

Je travaille avec le système d'exploitation GNU/Linux Kubuntu 12.04 64 bits et l'IDE Arduino 1.0.5. et j'utilise pour mes testes les produits suivants :

1 x Contrôleur Arduino Mega R3 :
http://dx.com/p/mega-2560-r3-atmega2560-16au-board-usb-cable-for-arduino-black-blue-215579

1 x Planche d'expérimentation Circuit-Test MB-104 « BreadBoard ».
http://dx.com/p/solderless-breadboard-white-large-size-121529

1 x Boîtier a 6 piles AA 1.5V (9V) et connecteur pour Arduino :
http://dx.com/p/6-x-aa-batteries-holder-with-dc2-1-power-jack-for-arduino-126413

1 x Adaptateur secteur pour Arduino, 9V, 1A, câble 100cm) :
http://dx.com/p/arduino-9v-1a-power-adapter-black-2-flat-pin-plug-100cm-cable-126288

1 x Carte a écran LCD LCD1602 :
http://dx.com/p/1602a-16-x-2-lines-white-character-lcd-module-w-blue-backlight-dc-5v-151978

1 x Capteur infrarouges VS1838B (TSOP1838) :
http://dx.com/p/tsop1838-ir-infrared-37-9khz-receiver-18m-range-2-7-5-5v-135045
http://www.dipmicro.com/store/VS1838B
http://dx.com/s/1838

1 x Mini télécommande type MP3 :
http://dx.com/p/ir-remote-control-diy-kit-for-arduino-1-x-cr2025-136284

ZL-3 Robot Raider Car Kits (2 x Moteur CC 318V 77RPM, supports et fixations) :
http://dx.com/p/zl-3-robot-raider-car-kits-for-arduino-153030
Ou :
2 x Moteur à courant continu N20 (CC 1.5V12V) avec engrenage réducteur :
http://dx.com/p/n20-diy-metal-gear-for-car-dc-motor-speed-regulating-motor-reducer-silver-golden-214121

1 x Contrôleur moteur L298N (H-Bridge) pour 2 moteurs CC ou 1 moteur Pas-A-Pas () :
http://dx.com/p/l298n-stepper-motor-driver-controller-board-module-blue-149662
http://www.datasheetarchive.com/dlmain/Datasheets-5/DSA-95443.pdf
http://www.datasheetarchive.com/dlmain/Datasheets-25/DSA-480678.pdf

2 x Servomoteur Toward Pro MG996R et accessoires :
http://dx.com/p/mg996r-metal-gear-digital-torque-servos-with-gears-and-parts-35763
ou
2 x Mini Servomoteur Tower Pro SG90 et accessoires :
http://dx.com/p/towerpro-sg90-mini-plastic-gear-steering-servo-3-pcs-set-187776

1 x Module ultrason émetteur capteur HR-SC04.
http://dx.com/p/hc-sr04-ultrasonic-sensor-distance-measuring-module-133696

Cordialement,

René

File isn't closed before being released, it leaks. This test has been verified and tested many times.

Fixed a typo in the WebServer example.

Make USB Serial_::begin() function take an unsigned long argument for consistency with HardwareSerial. Signed-off-by: Paul Brook <[email protected]>

Add two argument form of Serial_::begin Signed-off-by: Paul Brook <[email protected]>

Updated constructor and dependent code, other minor fixes. Robot LCD examples all compile, but not yet tested against actual hardware.

Latest Adafruit_GFX fixes + moved GFX lib to utility folder

…ook-usb-serial-begin

Fix indentation (cosmetic)

Fix for #814, Memory Leak

…lose/destructed objects #814

add preference to enable/disable line numbers and make font change work

Fix the line number font rendering problem on the Mac. Now, the TextAreaLineNumbers class extends the TextAreaPainter and just overloads the paintLine method to make it render the line number instead of rendering the whole line. Other than that, the superclass' drawing code is used. So: the same drawing code that renders the source code text in the editor is now also being used to render the line numbers.

Fixes #925

…ave a built-in LED. Fixes #758

removed pachube examples, added xively examples. changes to the Servo examples

Updated description of the file

Changed variable to unsigned long.

moved lcd.begin() to the beginnng of the setup() and fixed an issue that prevented the example from compiling. When calling lcd.write() with an argument of 0, the 0 must be cast a s a byte.

"index" variable name create conflicts with Arduino Due where "index" is a reserved word for Posix C.

Adding power connections, just to be thorough

Update HelloWorld.ino - Added two lines for documentation

Fix of a bug #2199

SPI: remove duplicate BarometricPressureSensor example

This is an empty stub to simply allow use of complex types with a non global static lifetime. For more complex handling the function 'atexit' can be redefined in user code. For more information see: #2229 #1919

ArduinoBot · 2014-08-22T11:51:45Z

Can I build this pull request?

LamiRene · 2014-08-22T12:21:57Z

Yes, you can!

ffissore · 2014-08-22T12:35:26Z

@LamiRene Sorry for the automated ArduinoBot comment.

fix Descriptor.c

Signed-off-by: Arnav Gupta <[email protected]>

set correct max size for mega2560 (to address issue #2277)

Comment says ALT+s, code says ALT+l. This remedies that difference.

Fix typo in KeyboardLogout.ino

…49152-65535.

Change EthernetClient to use IANA recommended ephemeral port range

Fixes #2343

Fixes #2379

This reverts commit f40e471. Added an hint for the buffer sizes. See #2057 Fixes #2367

bjelojac and others added 30 commits April 25, 2013 13:46

Fix for #814, Memory Leak

2aee42a

File isn't closed before being released, it leaks. This test has been verified and tested many times.

Fixed a typo in the WebServer example.

24df3ab

Merge pull request #1526 from interwho/master

0f0d5fe

Fixed a typo in the WebServer example.

USB serial baud arg type

1162a45

Make USB Serial_::begin() function take an unsigned long argument for consistency with HardwareSerial. Signed-off-by: Paul Brook <[email protected]>

USB CDC two argument begin()

f53fcdd

Add two argument form of Serial_::begin Signed-off-by: Paul Brook <[email protected]>

Latest Adafruit_GFX fixes + moved GFX lib to utility folder

a06ccb7

Updated constructor and dependent code, other minor fixes. Robot LCD examples all compile, but not yet tested against actual hardware.

Merge pull request #1566 from PaintYourDragon/master

5615e20

Latest Adafruit_GFX fixes + moved GFX lib to utility folder

Merge branch 'usb-serial-begin' of github.com:pbrook/Arduino into pbr…

a0b9d95

…ook-usb-serial-begin

Fix indentation (cosmetic)

aaafaf3

Merge pull request #1608 from supcik/fix_indent

a340140

Fix indentation (cosmetic)

Merge pull request #1383 from bjelojac/patch-1

6732677

Fix for #814, Memory Leak

It was still using jdk FileNameExtensionFilter

21ef50b

Added missing class FileNameExtensionFilter

72440e7

Removed destructor from File.cpp and SD.h as it leads to unexpected c…

e21b182

…lose/destructed objects #814

Update readme.txt

128678c

Display line numbers for the file being edited

787f73d

add preference to enable/disable line numbers

a2111fd

add preference to enable/disable line numbers and make font change work

Added Arduino Ethernet variant.

5373883

Fixes #925

Added LED_BUILTIN constant to Leonardo board

350eb86

Changed LED_BUILTIN to a macro to better support boards that do not h…

9b519f2

…ave a built-in LED. Fixes #758

Help 3rd party installers find the hardware path

ae265a9

Merge branch 'cayci-master'

89d6841

Fix robot problems regarding new version of Arduino

4cb0b11

Updates to a number of Examples

cb9686d

removed pachube examples, added xively examples. changes to the Servo examples

Added SERIAL metadata into variant files.

e7c24c6

Updated listfiles SD example

4869f7f

Updated description of the file

Updated Blink without delay example

83ef181

Changed variable to unsigned long.

Modified LCD custom character example

b332904

moved lcd.begin() to the beginnng of the setup() and fixed an issue that prevented the example from compiling. When calling lcd.write() with an argument of 0, the 0 must be cast a s a byte.

Updated KeyboardMessage example

b79ee02

cmaglie and others added 9 commits July 2, 2014 15:44

Fixed Smoothing example

faa0845

"index" variable name create conflicts with Arduino Due where "index" is a reserved word for Posix C.

Update HelloWorld.ino

f34787d

Adding power connections, just to be thorough

Merge pull request #2162 from ankitdaf/patch-2

3a8ad75

Update HelloWorld.ino - Added two lines for documentation

SPI: remove duplicate BarometricPressureSensor example

2c10bbe

Fix of a bug

865594d

Fix of a spelling mistake

97dc72c

Merge pull request #2206 from amulya349/master

163b60e

Fix of a bug #2199

Merge pull request #2195 from pmjdebruijn/duplicate-example

e71bbf6

SPI: remove duplicate BarometricPressureSensor example

Added replacement stub for cstdlib atexit() funciton.

1bbcb2f

This is an empty stub to simply allow use of complex types with a non global static lifetime. For more complex handling the function 'atexit' can be redefined in user code. For more information see: #2229 #1919

LamiRene closed this Aug 22, 2014

ffissore reopened this Aug 22, 2014

QuentinPerez and others added 15 commits August 25, 2014 09:52

fix Descriptor.c

70bc562

Merge pull request #2258 from QuentinPerez/fix-descriptor-firmware

e9e257b

fix Descriptor.c

Removed todo.txt (leftover) and updated build.xml accordingly

88b487f

Updated revision log. Version upped to 1.0.6.

90bd172

set correct max size for mega2560 (to address issue #2277)

4dd931a

Signed-off-by: Arnav Gupta <[email protected]>

Merge pull request #2316 from championswimmer/1.0.x-fixMaxMega

cd015f4

set correct max size for mega2560 (to address issue #2277)

Fix typo in KeyboardLogout.ino

d3f76e9

Comment says ALT+s, code says ALT+l. This remedies that difference.

Merge pull request #2329 from Unh0lyTigg/patch-1

ad0bedc

Fix typo in KeyboardLogout.ino

Changed EthernetClient to use IANA recommended ephemeral port range, …

c01172c

…49152-65535.

Merge pull request #2345 from JChristensen/ephemeral

d63350b

Change EthernetClient to use IANA recommended ephemeral port range

GSM: Backported library from IDE 1.5.x

afc368b

Fixes #2343

Upped version to 1.0.7. Update revision log.

ed5ad42

Fixed missing NOT_AN_INTERRUPT constant in digitalPinToInterrupt()

58b6fd4

Fixes #2379

Revert "Match return value to type in available()"

62cf4b6

This reverts commit f40e471. Added an hint for the buffer sizes. See #2057 Fixes #2367

Updated revision log

54a6d64

cmaglie closed this Oct 29, 2014

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

PWM and Lib Servo bug #1614

PWM and Lib Servo bug #1614

LamiRene commented Oct 10, 2013

ArduinoBot commented Aug 22, 2014

LamiRene commented Aug 22, 2014

ffissore commented Aug 22, 2014

PWM and Lib Servo bug #1614

PWM and Lib Servo bug #1614

Conversation

LamiRene commented Oct 10, 2013

if defined(AVR_ATmega1280) || defined(AVR_ATmega2560)

define _useTimer5

define _useTimer1

define _useTimer3

define _useTimer4

if defined(AVR_ATmega1280) || defined(AVR_ATmega2560)

define _useTimer1

define _useTimer3

define _useTimer4

define _useTimer5

elif defined(AVR_AT90USB646) || defined(AVR_AT90USB1286)

define _useTimer3

define _useTimer1

elif defined(AVR_AT90USB646) || defined(AVR_AT90USB1286)

define _useTimer1

define _useTimer3

if defined(AVR_ATmega1280) || defined(AVR_ATmega2560)

define _useTimer5

define _useTimer1

define _useTimer3

define _useTimer4

if defined(AVR_ATmega1280) || defined(AVR_ATmega2560)

define _useTimer1

define _useTimer3

define _useTimer4

define _useTimer5

elif defined(AVR_AT90USB646) || defined(AVR_AT90USB1286)

define _useTimer3

define _useTimer1

elif defined(AVR_AT90USB646) || defined(AVR_AT90USB1286)

define _useTimer1

define _useTimer3

ArduinoBot commented Aug 22, 2014

LamiRene commented Aug 22, 2014

ffissore commented Aug 22, 2014