-
-
Notifications
You must be signed in to change notification settings - Fork 7k
Added the last three zero-error (for a 16 MHz system clock) Baud rate… #5658
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Hi @dsstutts , I think you had a problem with file permissions (all became executable) and got committed. Would you mind fixing it and force pushing over your previous commit? |
…s (500,000.0, 1,000,000.0, and 2,000,000.0) to the list of available serial speeds in SerialMonitor.java. All performed flawlessly in my tests.
Martino,
Sorry about that! When I first tried to build the app after my changes, the build failed because the GET of liblistSerials-1.2.0.zip failed (the .zip was incomplete or corrupted), so thinking that there was a issue with my git clone, I built from a zipped master I downloaded with no changes. This one built fine, as an uncorrupted and complete liblistSerials-1.2.0.zip was downloaded. I then simply copied the whole unzipped directory into my repo — in retrospect, obviously a dumb thing to do — failing to realize that gunzip creates a 0777 copy of everything in the zip! DOH!
My solution was to simply re-clone the Arduino Master, make the one change, and force-push to my remote.
I don’t know why my first attempts to build from my git clone resulted in a filed GET during the build process, but the downloaded zipped version ran to completion; do you have any idea why this might happen?
Thanks for catching that, and best regards,
Dan
--
Dr. Daniel S. Stutts
Associate Professor of Mechanical Engineering
Missouri University of Science and Technology
282 Toomey Hall
400 West 13th St.
Rolla, MO 65409-0050
(573) 341-4084<tel:%28573%29%20341-4084>
Fax: (573) 341-4607<tel:%28573%29%20341-4607>
http://www.mst.edu/~stutts
From: Martino Facchin <[email protected]<mailto:[email protected]>>
Reply-To: arduino/Arduino <[email protected]<mailto:[email protected]>>
Date: Thursday, December 1, 2016 at 2:28 AM
To: arduino/Arduino <[email protected]<mailto:[email protected]>>
Cc: Daniel Stutts <[email protected]<mailto:[email protected]>>, Mention <[email protected]<mailto:[email protected]>>
Subject: Re: [arduino/Arduino] Added the last three zero-error (for a 16 MHz system clock) Baud rate… (#5658)
Hi @dsstutts<https://github.com/dsstutts> , I think you had a problem with file permissions (all became executable) and got committed. Would you mind fixing it and force pushing over your previous commit?
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub<#5658 (comment)>, or mute the thread<https://github.com/notifications/unsubscribe-auth/AAzt0HX_vfisRynxNJIQaoOLU3YyJYw-ks5rDoUagaJpZM4LA0Ws>.
|
Martino,
I just tried to build from my newly-cloned Arduino master, and found that liblistSerials is still being corrupted during the GET process. I’ve attached the offending file FYI. It appears to be incomplete since the uncorrupted version is 394 KB. The build completed successfully when I replaced it with the one complete liblistSerials-1.2.0.zip that downloaded with I ran the build from the zipped master that I downloaded.
I’m working on a MacBook Pro running El Capitan Vers. 10.11.6 (15G1108) with java Vers. 1.8.0_92, Java SE RE build 1.8.0_92-b14.
Any suggestions as to what might be going on here?
Again, best regards,
Dan
--
Dr. Daniel S. Stutts
Associate Professor of Mechanical Engineering
Missouri University of Science and Technology
282 Toomey Hall
400 West 13th St.
Rolla, MO 65409-0050
(573) 341-4084<tel:%28573%29%20341-4084>
Fax: (573) 341-4607<tel:%28573%29%20341-4607>
http://www.mst.edu/~stutts
From: Martino Facchin <[email protected]<mailto:[email protected]>>
Reply-To: arduino/Arduino <[email protected]<mailto:[email protected]>>
Date: Thursday, December 1, 2016 at 2:28 AM
To: arduino/Arduino <[email protected]<mailto:[email protected]>>
Cc: Daniel Stutts <[email protected]<mailto:[email protected]>>, Mention <[email protected]<mailto:[email protected]>>
Subject: Re: [arduino/Arduino] Added the last three zero-error (for a 16 MHz system clock) Baud rate… (#5658)
Hi @dsstutts<https://github.com/dsstutts> , I think you had a problem with file permissions (all became executable) and got committed. Would you mind fixing it and force pushing over your previous commit?
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub<#5658 (comment)>, or mute the thread<https://github.com/notifications/unsubscribe-auth/AAzt0HX_vfisRynxNJIQaoOLU3YyJYw-ks5rDoUagaJpZM4LA0Ws>.
|
Merged as a095d2a, thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
…s (500,000.0, 1,000,000.0, and 2,000,000.0) to the list of available serial speeds in SerialMonitor.java. All performed flawlessly in my tests.