Skip to content

File Manager view triggers file-list on switch. #184

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
Apr 15, 2025

Conversation

ubidefeo
Copy link
Collaborator

No description provided.

@ubidefeo ubidefeo requested review from sebromero and Copilot April 11, 2025 14:18
Copilot

This comment was marked as resolved.

@ubidefeo ubidefeo self-assigned this Apr 12, 2025
@sebromero
Copy link
Collaborator

@ubidefeo Can you provide some information why you added a "sleep"? What was the issue?
There might be a cleaner way to solve it.

@ubidefeo
Copy link
Collaborator Author

ubidefeo commented Apr 14, 2025

@sebromero
the stop immediately followed by another command can send slower boards into RAW PASTE and they get stuck

Copy link
Collaborator

@sebromero sebromero left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please add a comment for why we added the sleep

}
if(view === 'file-manager') {
emitter.emit('stop')
await sleep(500)
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
await sleep(500)
await sleep(500) // Give the board time to stop the program and return to the prompt

Copy link
Collaborator

@sebromero sebromero left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@ubidefeo ubidefeo merged commit 1a2b11d into development Apr 15, 2025
1 check passed
@ubidefeo ubidefeo deleted the fix/filemanager-update-file-list branch April 15, 2025 08:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants