Skip to content

Implement Pluggable Discovery protocol v1 #6

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 9 commits into from
Jun 8, 2021
Merged

Implement Pluggable Discovery protocol v1 #6

Changes from 1 commit
Commits
Show all changes
9 commits
Select commit Hold shift + click to select a range
adaf607
Factored json output and added Error field
cmaglie Jun 3, 2021
0b87821
Implemented HELLO cmd
cmaglie Jun 3, 2021
51184d9
Implemented ERROR protocol
cmaglie Jun 3, 2021
d70b1fb
Port does not have identification properties anymore
cmaglie Jun 3, 2021
f1fd9f3
Report protocol on 'remove' event
cmaglie Jun 3, 2021
87c2119
Updated readme
cmaglie Jun 3, 2021
3b72f45
Update README.md
cmaglie Jun 4, 2021
e45938d
Change ProtocolVersion field to int
cmaglie Jun 8, 2021
497dea0
Removed commented code
cmaglie Jun 8, 2021
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
Update README.md 
Co-authored-by: per1234 <[email protected]>
  • Loading branch information
@cmaglie @per1234
cmaglie and per1234 authored Jun 4, 2021
commit 3b72f452119cdc3bd35cb55365b51afa27f27fa9
2 changes: 1 addition & 1 deletion README.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -25,7 +25,7 @@ or:

`HELLO 1 "arduino-cli"`

in this case the protocol version requested by the clien is `1` (at the moment of writing there were no other revisions of the protocol).
in this case the protocol version requested by the client is `1` (at the moment of writing there were no other revisions of the protocol).
The response to the command is:

```json
Expand Down