Reapply "Add Cobalt Cloud machine Azure CI profile and runs. (#2088)" (#2089) #2090
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…2088)" (aspnet#2089) This reverts commit ed6ac8c.
There was a problem hiding this comment.
Pull Request Overview
This PR reintroduces the Cobalt Cloud machine Azure CI profile to restore proper service bus connectivity. Key changes include:
- Adding new Cobalt Cloud Linux jobs to both the benchmarks matrix and CI pipeline files.
- Updating job dependencies to incorporate the new Cobalt Cloud jobs.
- Defining new Azure profile configurations for cobalt-cloud-lin and cobalt-cloud-lin-relay.
Reviewed Changes
Copilot reviewed 3 out of 3 changed files in this pull request and generated 1 comment.
| File | Description |
|---|---|
| build/benchmarks.matrix.azure.yml | Added Cobalt Cloud queue and job groups for CI testing |
| build/benchmarks-ci-azure.yml | Introduced new Cobalt Cloud jobs and updated dependencies in the pipeline |
| build/azure.profile.yml | Added new profile definitions for cobalt-cloud-lin and cobalt-cloud-lin-relay |
Comments suppressed due to low confidence (1)
build/benchmarks-ci-azure.yml:72
- [nitpick] Consider aligning the naming convention between 'cobaltcloud' used for serviceBusQueueName and 'cobalt-cloud-lin' for the profile to improve clarity and consistency across the configuration.
serviceBusQueueName: cobaltcloud
| - https://aspnetperf.servicebus.windows.net/azurearm64client | ||
| aliases: | ||
| - warmup | ||
| - secondary | ||
|
|
There was a problem hiding this comment.
[nitpick] Consider adding brief documentation or comments to clarify the purpose and configuration details for the new cobalt cloud profiles, which can help improve maintainability.
Suggested change
| # Profile for the Cobalt Cloud Linux environment. | |
| # This profile is used for deployments in the Cobalt Cloud infrastructure | |
| # with direct HTTP endpoints for database, application, and load services. |
Copilot uses AI. Check for mistakes.
sebastienros
approved these changes
May 9, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Reapply "Add Cobalt Cloud machine Azure CI profile and runs. (#2088)" (#2089)
This reverts commit ed6ac8c.
The service bus connection should be working properly now so remerging this. (Docker logs showed message pulled from service bus instead of connection error).
Working test run here: https://dev.azure.com/dnceng/internal/_build/results?buildId=2705137&view=results, shows that the service bus connection is now working. (The test run no longer has the profile available, so it is failing, but it shows that the service bus connection is working).