This repository was archived by the owner on Apr 8, 2020. It is now read-only.
Added support for Thenables #1459
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
|
Contributor
Author
|
@natemcmaster Does anyone look at PRs in the project? |
Contributor
|
Paging @SteveSandersonMS @Eilon. @waterfoul I don't have enough context on this piece of code to know if this is something we want, sorry. |
Contributor
Author
|
@natemcmaster Any suggestions on getting this some attention? It brings the webpack support up to snuff with the documentation and we are having to resort to including a .tar file in all of our projects in order to use the patched code. |
Contributor
|
I'll use my internal email powers to ping the right people again. |
Member
|
Thanks for contributing this! It's now merged (with some stylistic tweaks - hope you don't mind). |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.