Skip to content

Conversation

@ngeojiajun-deriv
Copy link

No description provided.

Copy link

@review-deriv review-deriv left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

PR description is too short. You can use this format:

# Description
This is a summary of the changes. This should describe why do we need this change.
Whys and Hows come here.

# Cards
* https://clickup.com/12345
* https://clickup.com/12346

@ngeojiajun-deriv
Copy link
Author

Why changing the base image for myriad? The package should have been installed automatically during the build process

@ngeojiajun-deriv ngeojiajun-deriv changed the base branch from master to perl_40 January 13, 2025 09:56
Copy link

@review-deriv review-deriv left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

PR description is too short. You can use this format:

# Description
This is a summary of the changes. This should describe why do we need this change.
Whys and Hows come here.

# Cards
* https://clickup.com/12345
* https://clickup.com/12346

Copy link

@diego-deriv diego-deriv left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

should this build both branches?

@ngeojiajun-deriv
Copy link
Author

Yes and no, we need at least the changes for perl_40 but I simply update the one for master so it is easily to reconcile the changes later

ENV DEBIAN_FRONTEND=noninteractive
ENV PERL_VERSION=5.36.0
ENV PERL_SHA256=0f386dccbee8e26286404b2cca144e1005be65477979beb9b1ba272d4819bcf0
ENV PERL_VERSION=5.40.0

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

how sure are we regarding this working on the usual images depending on this, like dzil & myriad

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is tested at least on our stuffs, on the latest myriad upgrade attempt

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

6 participants