Skip to content

fix: adjust label opacity #4700

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Apr 25, 2025
Merged

fix: adjust label opacity #4700

merged 1 commit into from
Apr 25, 2025

Conversation

lukewalczak
Copy link
Member

@lukewalczak lukewalczak commented Apr 25, 2025

Motivation

This PR fixes the opacity behavior of labels in the BottomNavigationBar component - fix properly applies active/inactive opacity values based on the component's state and version.

Related issue

Fixes: #4369
Fixes: #4348

Test plan

empty label when not focused bold label for focused
label_for_focused_tab bottom_navigation_bold_focused

Copy link

The mobile version of example app from this branch is ready! You can see it here.

@lukewalczak lukewalczak merged commit 0889b0b into main Apr 25, 2025
3 checks passed
@lukewalczak lukewalczak added this to the 5.13.5 milestone Apr 25, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

BottomNavigation.Bar renderLabel can't hide in inactive tabs Bottom Tabs focused prop
1 participant