Skip to content

Commit 12d9d77

Browse files
author
Stephane Landelle
committed
Only compute StringData bytes once, close AsyncHttpClient#263
1 parent d13f741 commit 12d9d77

File tree

1 file changed

+3
-2
lines changed

1 file changed

+3
-2
lines changed

providers/netty/src/main/java/com/ning/http/client/providers/netty/NettyAsyncHttpProvider.java

Lines changed: 3 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -779,8 +779,9 @@ else if (uri.getRawQuery() != null)
779779
nettyRequest.setHeader(HttpHeaders.Names.CONTENT_LENGTH, String.valueOf(request.getByteData().length));
780780
nettyRequest.setContent(ChannelBuffers.wrappedBuffer(request.getByteData()));
781781
} else if (request.getStringData() != null) {
782-
nettyRequest.setHeader(HttpHeaders.Names.CONTENT_LENGTH, String.valueOf(request.getStringData().getBytes(bodyCharset).length));
783-
nettyRequest.setContent(ChannelBuffers.wrappedBuffer(request.getStringData().getBytes(bodyCharset)));
782+
byte[] bytes = request.getStringData().getBytes(bodyCharset);
783+
nettyRequest.setHeader(HttpHeaders.Names.CONTENT_LENGTH, String.valueOf(bytes.length));
784+
nettyRequest.setContent(ChannelBuffers.wrappedBuffer(bytes));
784785
} else if (request.getStreamData() != null) {
785786
int[] lengthWrapper = new int[1];
786787
byte[] bytes = AsyncHttpProviderUtils.readFully(request.getStreamData(), lengthWrapper);

0 commit comments

Comments
 (0)