Skip to content

NettyAsyncHttpProvider generates bytes from StringData twice #263

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
slandelle opened this issue Mar 24, 2013 · 2 comments
Closed

NettyAsyncHttpProvider generates bytes from StringData twice #263

slandelle opened this issue Mar 24, 2013 · 2 comments
Assignees
@slandelle
Milestone
1.7.13

Comments

@slandelle
Copy link
Contributor 

nettyRequest.setHeader(HttpHeaders.Names.CONTENT_LENGTH, String.valueOf(request.getStringData().getBytes(bodyCharset).length));
nettyRequest.setContent(ChannelBuffers.wrappedBuffer(request.getStringData().getBytes(bodyCharset)));
@ghost ghost assigned slandelle Mar 24, 2013
slandelle pushed a commit that referenced this issue Mar 25, 2013
Only compute StringData bytes once, close #263
8283b33
@jfarcand
Copy link
Contributor

Don't tell anyone I wrote that :)

@slandelle
Copy link
Contributor Author

Well, as I will start digging into Netty support, I might find out more of those, be warned ;)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@slandelle slandelle

Labels
None yet
Projects
None yet
Milestone
1.7.13
Development

No branches or pull requests
2 participants
@jfarcand @slandelle