Support redis & GCS token DB backing in Google & OIDC auth #373
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
andsens
force-pushed
the
main
branch
4 times, most recently
from
f80b0bb to
d58fca6
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
It's currently not possible to do a HA of either OIDC or Google auth. This PR generalizes the redis and GCS backings used in the GitHub and GitLab auth methods and utilizes them in OIDC and Google auth when configured.
Also, unless I missed something, the http timeouts were not respected in any of the clients. I fixed that too.
This builds, but I haven't even tried running it yet, hence the draft status. Just thought I'd get this out here for early feedback.
This is like #365 without the package version bumps