Changed _pools initialization to an empty object #1
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What happens?
_pools is initialized as an empty array but values are stored and retrieved as object keys.
For example I have an object that looks like this in the inspector:
What did you expect to happen?
I'm not sure if this is by design or not. I was expecting an easily-iterable object of some sort, either an array of objects or a plain object with keys. Sure, I could iterate over the Array instance's own keys but that's messy. It feels like this should just have been instantiated as an object.
Use case
I understand this is a private variable. I use it to inspect the pool level for debugging and performance purposes only.
Thank you for your time and for such a great open source project! 🍻