[Secrets Store] Review for consistency and clarity in examples and limits #21795
Conversation
github-actions
bot
added
product:secrets-store
product:workers
|
Howdy and thanks for contributing to our repo. The Cloudflare team reviews new, external PRs within two (2) weeks. If it's been two weeks or longer without any movement, please tag the PR Assignees in a comment. We review internal PRs within 1 week. If it's something urgent or has been sitting without a comment, start a thread in the Developer Docs space internally. PR Change SummaryEnhanced the Secrets Store documentation by incorporating partials and improving examples for better clarity and usability.
Modified Files
How can I customize these reviews?Check out the Hyperlint AI Reviewer docs for more information on how to customize the review. If you just want to ignore it on this PR, you can add the Note specifically for link checks, we only check the first 30 links in a file and we cache the results for several hours (for instance, if you just added a page, you might experience this). Our recommendation is to add |
RebeccaTamachiro
changed the title
RebeccaTamachiro
requested review from
a team,
irvinebroque and
ToriLindsay
as code owners
| @@ -112,7 +112,7 @@ To bind an account secret to your Worker, you must have one of the following [ro | |||
| ```toml | |||
| main = "./src/index.js" | |||
| secrets_store_secrets = [ | |||
| { binding = "MY_SECRETS_STORE_SECRET", store_id= "<STORE_ID>", secret_name = "<MY_SECRET_NAME>" } | |||
| { binding = "secrets_store_binding", store_id= "<STORE_ID>", secret_name = "<MY_SECRET_NAME>" } | |||
There was a problem hiding this comment.
Just to double check. In binding = the customer isn't supposed to input their secret; rather they should write the var "secrets_store_binding"?
There was a problem hiding this comment.
Not really. I think originally it wasn't added as a placeholder (in between < > ) bc of the concrete example at the bottom but I'll update both to have the placeholders instead. Thank you!
Summary
PCX-16696