Skip to content

[WAF] Improve linking #21874

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Apr 22, 2025
Merged

Conversation

pedrosousa
Copy link
Contributor

Summary

Partially addresses PCX-16221.

@pedrosousa pedrosousa requested review from a team and ranbel as code owners April 22, 2025 09:41
Copy link
Contributor

hyperlint-ai bot commented Apr 22, 2025

Howdy and thanks for contributing to our repo. The Cloudflare team reviews new, external PRs within two (2) weeks. If it's been two weeks or longer without any movement, please tag the PR Assignees in a comment.

We review internal PRs within 1 week. If it's something urgent or has been sitting without a comment, start a thread in the Developer Docs space internally.


PR Change Summary

Enhanced documentation for WAF and Terraform integration by adding API references and clarifications.

  • Added API resource links for creating rate limiting rules and custom rulesets in WAF documentation.
  • Included Terraform configuration references across multiple WAF-related pages.
  • Clarified deployment procedures for managed rulesets and custom rulesets.

Modified Files

  • src/content/docs/terraform/additional-configurations/rate-limiting-rules.mdx
  • src/content/docs/terraform/additional-configurations/waf-custom-rules.mdx
  • src/content/docs/terraform/additional-configurations/waf-managed-rulesets.mdx
  • src/content/docs/waf/account/custom-rulesets/create-api.mdx
  • src/content/docs/waf/account/managed-rulesets/deploy-api.mdx
  • src/content/docs/waf/account/rate-limiting-rulesets/create-api.mdx
  • src/content/docs/waf/custom-rules/create-api.mdx
  • src/content/docs/waf/managed-rules/deploy-api.mdx
  • src/content/docs/waf/rate-limiting-rules/create-api.mdx

How can I customize these reviews?

Check out the Hyperlint AI Reviewer docs for more information on how to customize the review.

If you just want to ignore it on this PR, you can add the hyperlint-ignore label to the PR. Future changes won't trigger a Hyperlint review.

Note specifically for link checks, we only check the first 30 links in a file and we cache the results for several hours (for instance, if you just added a page, you might experience this). Our recommendation is to add hyperlint-ignore to the PR to ignore the link check for this PR.

@github-actions github-actions bot added product:terraform Related to Terraform product product:waf labels Apr 22, 2025
Copy link
Contributor

Preview URL: https://8fba5ae0.preview.developers.cloudflare.com
Preview Branch URL: https://pedro-pcx-16221-waf-improve-linking.preview.developers.cloudflare.com

Files with changes (up to 15)

Original Link Updated Link
https://developers.cloudflare.com/terraform/additional-configurations/waf-custom-rules/ https://pedro-pcx-16221-waf-improve-linking.preview.developers.cloudflare.com/terraform/additional-configurations/waf-custom-rules/
https://developers.cloudflare.com/terraform/additional-configurations/waf-managed-rulesets/ https://pedro-pcx-16221-waf-improve-linking.preview.developers.cloudflare.com/terraform/additional-configurations/waf-managed-rulesets/
https://developers.cloudflare.com/terraform/additional-configurations/rate-limiting-rules/ https://pedro-pcx-16221-waf-improve-linking.preview.developers.cloudflare.com/terraform/additional-configurations/rate-limiting-rules/
https://developers.cloudflare.com/waf/account/custom-rulesets/create-api/ https://pedro-pcx-16221-waf-improve-linking.preview.developers.cloudflare.com/waf/account/custom-rulesets/create-api/
https://developers.cloudflare.com/waf/account/managed-rulesets/deploy-api/ https://pedro-pcx-16221-waf-improve-linking.preview.developers.cloudflare.com/waf/account/managed-rulesets/deploy-api/
https://developers.cloudflare.com/waf/account/rate-limiting-rulesets/create-api/ https://pedro-pcx-16221-waf-improve-linking.preview.developers.cloudflare.com/waf/account/rate-limiting-rulesets/create-api/
https://developers.cloudflare.com/waf/custom-rules/create-api/ https://pedro-pcx-16221-waf-improve-linking.preview.developers.cloudflare.com/waf/custom-rules/create-api/
https://developers.cloudflare.com/waf/managed-rules/deploy-api/ https://pedro-pcx-16221-waf-improve-linking.preview.developers.cloudflare.com/waf/managed-rules/deploy-api/
https://developers.cloudflare.com/waf/rate-limiting-rules/create-api/ https://pedro-pcx-16221-waf-improve-linking.preview.developers.cloudflare.com/waf/rate-limiting-rules/create-api/

@pedrosousa pedrosousa merged commit 2c209b3 into production Apr 22, 2025
13 checks passed
@pedrosousa pedrosousa deleted the pedro/PCX-16221-waf-improve-linking branch April 22, 2025 10:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
product:terraform Related to Terraform product product:waf size/s
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants