Parameterize recovery module tests so they run against all congestion control algorithms. #2012
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
antoniovicente
commented
Apr 10, 2025
| @@ -1301,7 +1324,7 @@ mod tests { | |||
| is_app_limited: false, | |||
| tx_in_flight: 0, | |||
| lost: 0, | |||
| has_data: false, | |||
| has_data: true, | |||
There was a problem hiding this comment.
bbr2_gcongestion ignores sends with has_data set to false.
antoniovicente
force-pushed
the
test/recovery_v2
branch
2 times, most recently
from
13bb0de to
c686262
Compare
antoniovicente
commented
Apr 10, 2025
| assert_eq!( | ||
| r.get_packet_send_time(now) - now, | ||
| Duration::from_secs_f64(12000.0 / pacing_rate as f64) | ||
| Duration::from_secs_f64(scale_factor * 12000.0 / pacing_rate as f64) |
There was a problem hiding this comment.
The pacing rate for bbr2_gcongestion may be too conservative; it is sending 2.5x slower than all the other congestion control algorithms
antoniovicente
force-pushed
the
test/recovery_v2
branch
from
c686262 to
db578ea
Compare
ghedo
approved these changes
Apr 28, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As a pre-requisite, add Instant::now as an argument to get_packet_send_time so it can be driven by the test.