Skip to content

[pull] main from remix-run:main #122

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
May 5, 2025
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion .github/ISSUE_TEMPLATE/config.yml
Original file line number Diff line number Diff line change
Expand Up @@ -5,7 +5,7 @@ contact_links:
about: If you've got an idea for a new feature in React Router, please open a new Discussion with the `Proposals` label
- name: 🤔 Usage Question (Github Discussions)
url: https://github.com/remix-run/remix/discussions/new?category=q-a
about: Open a Discussion in GitHub wih the `Q&A` label
about: Open a Discussion in GitHub with the `Q&A` label
- name: 💬 Remix Discord Channel
url: https://rmx.as/discord
about: Interact with other people using React Router and Remix 📀
Original file line number Diff line number Diff line change
Expand Up @@ -32,7 +32,7 @@ export default function Route() {
}
```

For end-to-end type safety, it is then the user's responsability to make sure that `loader` and `action` also use the same type in the `json` generic:
For end-to-end type safety, it is then the user's responsibility to make sure that `loader` and `action` also use the same type in the `json` generic:

```ts
export const loader: LoaderFunction = () => {
Expand Down Expand Up @@ -108,7 +108,7 @@ export const loader: LoaderFunction = () => {

export default function Route() {
const { birthday } = useLoaderData<MyLoaderData>();
// ^ `useLoaderData` tricks Typescript into thinking this is a `Date`, when in fact its a `string`!
// ^ `useLoaderData` tricks Typescript into thinking this is a `Date`, when in fact it's a `string`!
}
```

Expand Down Expand Up @@ -144,7 +144,7 @@ Though `loader` and `useLoaderData` exist together in the same file at developme
Without the `loader` argument to infer types from, `useLoaderData` needs a way to learn about `loader`'s type at compile-time.

Additionally, `loader` and `useLoaderData` are both managed by Remix across the network.
While its true that Remix doesn't "own" the network in the strictest sense, having `useLoaderData` return data that does not correspond to its `loader` is an exceedingly rare edge-case.
While it's true that Remix doesn't "own" the network in the strictest sense, having `useLoaderData` return data that does not correspond to its `loader` is an exceedingly rare edge-case.

Same goes for `useActionData`.

Expand Down
2 changes: 1 addition & 1 deletion integration/fetcher-layout-test.ts
Original file line number Diff line number Diff line change
Expand Up @@ -231,7 +231,7 @@ test("fetcher calls index route loader when at index route", async ({
expect(dataElement.text()).toBe("index data");
});

test("fetcher calls layout route action when at paramaterized route", async ({
test("fetcher calls layout route action when at parameterized route", async ({
page,
}) => {
let app = new PlaywrightFixture(appFixture, page);
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -5135,7 +5135,7 @@ declare module "assets:*" {
// https://opensource.org/licenses/Apache-2.0
declare abstract class PipelineTransform {
/**
* transformJson recieves an array of javascript objects which can be
* transformJson receives an array of javascript objects which can be
* mutated and returned to the pipeline
* @param data The data to be mutated
* @returns A promise containing the mutated data
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -4272,7 +4272,7 @@ declare module "assets:*" {
// https://opensource.org/licenses/Apache-2.0
declare abstract class PipelineTransform {
/**
* transformJson recieves an array of javascript objects which can be
* transformJson receives an array of javascript objects which can be
* mutated and returned to the pipeline
* @param data The data to be mutated
* @returns A promise containing the mutated data
Expand Down
Loading