⚡️ Speed up function eval_answer
by 158%
#53
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
📄 158% (1.58x) speedup for
eval_answer
inevaluation/benchmarks/toolqa/utils.py
⏱️ Runtime :
4.44 milliseconds
→1.72 millisecond
(best of1165
runs)📝 Explanation and details
Changes Made.
(?:)
inremove_articles
to slightly improve regex performance.remove_punc
withstr.translate
andstr.maketrans
, which is generally faster for removing punctuation.normalize_answer
.normalize_answer
for bothpred
andanswer
to avoid recalculating them multiple times.These changes maintain the existing logic while improving execution speed and memory efficiency.
✅ Correctness verification report:
🌀 Generated Regression Tests Details
To edit these changes
git checkout codeflash/optimize-eval_answer-m8x4zka2
and push.