Fix mdformat 1.0.0 compatibility #19
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
OK I finished all my changes. @csala, can you trigger the CI workflows so we can see the effects? |
|
Hey @kdeldycke thanks for the proposal! I agree with many of the things that you are proposing, but I would prefer not to take this huge PR in at once and rather do things one by one. Would you mind making this PR strictly about issue #17, without any of the other unrelated changes (including #18, which I would like to treat separately) |
|
Yes, no worries! As in csala/mdformat-simple-breaks#4, I'll scale down the PR and make separate proposals. Thanks for the quick answer! :) |
kdeldycke
force-pushed
the
fix-mdformat-1.0.0
branch
2 times, most recently
from
3741bac to
344c474
Compare
kdeldycke
changed the title
.mdformat.toml takes precedence
kdeldycke
force-pushed
the
fix-mdformat-1.0.0
branch
2 times, most recently
from
8121b88 to
4300a2a
Compare
kdeldycke
force-pushed
the
fix-mdformat-1.0.0
branch
from
4300a2a to
d7d9cc0
Compare
|
@csala Just finish splitting up all changes into independent PRs. Also reduced the changes for each to their minimum. All are ready to be reviewed and merged upstream! :) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR closes: #18
Given the big changes, I couldn't help but try to update things left and right:
mdformat 1.0.0owns requirement)pytest >= 8.4.0(first version to support Python 3.14)Sorry if this PR feels a bit bigger in scope than simply fixing
mdformat 1.0.0compatibility. So please tell me if some changes are too aggressive in which case I'll be happy to scale down my propositions.