fixed #12753 - do not look for extension-less library files #7538
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
firewave
force-pushed
the
lib-noext
branch
6 times, most recently
from
e596241 to
b623647
Compare
This comment was marked as resolved.
This comment was marked as resolved.
firewave
changed the title
firewave
force-pushed
the
lib-noext
branch
2 times, most recently
from
5636d40 to
445378d
Compare
|
@ludviggunne maybe also review since you looked into something related. Thanks! |
ludviggunne
reviewed
Jun 2, 2025
|
|
||
| // TODO: what if the extension is not .cfg? | ||
| // only append extension when we provide the library name and not a path - TODO: handle relative paths? | ||
| if (!is_abs_path && Path::getFilenameExtension(fullfilename).empty()) |
There was a problem hiding this comment.
Maybe only allow extensionless as a shorthand if it's a single word? If you're supplying a path you might as well supply the whole filename.
There was a problem hiding this comment.
I was thinking the same thing. That's what the TODO is about. Will file a ticket about it and address it as a whole when the behavior is mostly aligned (i.e. no more TODO/skip/xfail in the Python test).
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.