Updating / Merging sources #1
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
To allow easier customization.
…format backward compatible Although different instances of subcircuits starts identical, they corresponds to distinct runtime object and their internal may deviate from each other due to edits done on each subcircuits. The current format disgard all the changes except for the first subcircuit and apply the edit on the first subcircuit to all instances during loading. This change modifies the saving format while keeping the file backward compatible so that the new file can still be openned by old code, with only minor display differences. This is done by automatically generate new celltype for each instances of the subcircuit on saving and saving the old value that is only useful for display in a separate attribute `disp_celltype`. This automatic name generation is also only done when there are multiple instances of the same cell type so that we can keep generating names shorter and the file as closed to the old format as possible.
This should make it easier for the user to recreate the windows on reload. In case we want to add more arguments, the model is placed in a context objects so that more options can be added easily without breaking anything.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.