Skip to content

the recommended_tag warning that bubbles up into vs code is flawed #121

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
willie opened this issue Apr 30, 2025 · 7 comments
Open

the recommended_tag warning that bubbles up into vs code is flawed #121

willie opened this issue Apr 30, 2025 · 7 comments

Comments

@willie
Copy link

willie commented Apr 30, 2025

I'm getting docker-language-server(recommended_tag) warnings for the latest LTS release and it's suggesting non LTS releases. I know LTS or not LTS isn't your problem, but it's an impediment to using the rest of the language server features.

@cas--
Copy link

cas-- commented May 7, 2025

I was puzzled by this squiggle for ubuntu 24.04

Image

It was also not immediately clear what 0C 0H 2M 6L referred to, but can now see it means 2 Medium and 6 Low vulnerabilities as listed on Ubuntu CVES, but it seems improbable that the two latest Ubuntu releases have zero vulnerabilities. I suspect that the lack of any listing for non-LTS on Ubuntu CVES (as used by docker scout) is returning no CVE issues.

Probably could improve on this recommendation to choose level of severity to warn about e.g. High or greater.

For now I will have to turn off this feature in settings: docker.lsp.experimental.vulnerabilityScanning

@rcjsuen
Copy link
Collaborator

rcjsuen commented May 7, 2025

@cdupuis Could you share your thoughts on how best to approach this?

@cdupuis
Copy link

cdupuis commented May 7, 2025

The missing CVEs on ubuntu:25.04 and ubuntu:24.10 are fixed now:

Image

@willie
Copy link
Author

willie commented May 8, 2025

I think that proves that it is a broken recommendation because the number of vulnerabilities in the "recommended" images are higher. And, still LTS.

@rcjsuen
Copy link
Collaborator

rcjsuen commented May 8, 2025

@willie I reproduced your concern about LTS vs unstable from the command line so I opened https://github.com/docker/scout-cli-plugin/issues/700.

@willie
Copy link
Author

willie commented May 8, 2025

@rcjsuen Thanks! I would subscribe to that issue, but I don't have access to that repo.

@rcjsuen
Copy link
Collaborator

rcjsuen commented May 8, 2025

Thanks! I would subscribe to that issue, but I don't have access to that repo.

Sorry about that and thanks for catching that. I forgot about that little detail. I opened docker/scout-cli#187 which is a public GitHub repository. 👍

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

4 participants