Fix link to related docs in the "Building best practices" manual #22469
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
the
area/build
✅ Deploy Preview for docsdocker ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
duffuniverse
commented
Apr 22, 2025
| @@ -147,7 +147,7 @@ Limiting each container to one process is a good rule of thumb, but it's not a | |||
| hard and fast rule. For example, not only can containers be | |||
| [spawned with an init process](/manuals/engine/containers/multi-service_container.md), | |||
| some programs might spawn additional processes of their own accord. For | |||
| instance, [Celery](https://docs.celeryproject.org/) can spawn multiple worker | |||
| instance, [Celery](https://docs.celeryq.dev/) can spawn multiple worker | |||
| processes, and [Apache](https://httpd.apache.org/) can create one process per | |||
| request. | |||
|
|
|||
There was a problem hiding this comment.
There is another stale documentation URL in the Dockerfile instructions --> ENTRYPOINT section.
This script uses the
execBash command so that the final running application becomes the container's PID 1.
Probably it could be substituted with a Linux manual page for the exec Bash command 💭
There was a problem hiding this comment.
Yes indeed, it needs to be changed in https://github.com/moby/buildkit/blob/master/frontend/dockerfile/docs/reference.md#entrypoint
duffuniverse
deleted the
fix-links-to-docs-in-building-best-practices-manual
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
The pull request fixes the stale Celery documentation URL.