security: domain management #22477
Merged
security: domain management #22477
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sarahsanders-docker
added
status/do-not-merge
sarahsanders-docker
requested review from
ivan-californias,
chrstnfrrs,
serjkarneichyk and
a team
✅ Deploy Preview for docsdocker ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
craig-osterhout
requested changes
Apr 28, 2025
There was a problem hiding this comment.
One small typo fix and then LGTM.
Some nonblocking suggestions:
- Suggest adding "Delete a domain" for Kapa food.
- Suggest moving the provisioning info to the provisioning section at https://deploy-preview-22477--docsdocker.netlify.app/security/for-admins/provisioning/. That current section is tightly coupled with SSO and implies that SSO is required for provisioning, contrary to what's said in this new topic.
fixed the typo and added "delete domain" section! I don't think moving this doc into Provisioning will help, because Provisioning is actually more tightly coupled with SSO. all of those docs link out to or are linked from an SSO doc, but this one is best to keep at the "for admins" top-level to not get them confused. it might be worth rethinking the information architecture of this section overall as we scale to de-couple SSO and make it its own section |
craig-osterhout
previously approved these changes
Apr 29, 2025
sarahsanders-docker
requested review from
craig-osterhout and
a team
and removed request for
ivan-californias,
chrstnfrrs,
serjkarneichyk and
aevesdocker
|
Added a new section on how it works to address concerns from support |
sarahsanders-docker
added a commit
to sarahsanders-docker/docs
that referenced
this pull request
May 9, 2025
## Description - Adds Domain management guide separate from Domain audit (open to discussing where else to put this) - Adds steps to add and verify a domain, removing mention of SSO ## Related issues or tickets - https://docker.atlassian.net/browse/ENGDOCS-2543 ## Reviews - [ ] Technical review - [ ] Editorial review - [ ] Product review
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Related issues or tickets
Reviews