-
Notifications
You must be signed in to change notification settings - Fork 7.7k
Update outdated url to ubuntu source code #22626
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
✅ Deploy Preview for docsdocker ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM thanks
@tianon @neersighted Can you PTAL? 🙏
@@ -442,7 +442,7 @@ reduces the image size, since the apt cache isn't stored in a layer. Since the | |||
`RUN` statement starts with `apt-get update`, the package cache is always | |||
refreshed prior to `apt-get install`. | |||
|
|||
Official Debian and Ubuntu images [automatically run `apt-get clean`](https://github.com/moby/moby/blob/03e2923e42446dbb830c654d0eec323a0b4ef02a/contrib/mkimage/debootstrap#L82-L105), so explicit invocation is not required. | |||
Official Debian and Ubuntu images [automatically run `apt-get clean`](https://git.launchpad.net/livecd-rootfs/tree/live-build/functions#n1003), so explicit invocation is not required. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
https://github.com/debuerreotype/debuerreotype/blob/c9542ab785e72696eb2908a6dbc9220abbabef39/scripts/debuerreotype-minimizing-config#L87-L109 would be a better link (especially as it has more explanation; I tried to convince the Ubuntu folks to copy/use it, but I wasn't convincing enough).
Official Debian and Ubuntu images [automatically run `apt-get clean`](https://git.launchpad.net/livecd-rootfs/tree/live-build/functions#n1003), so explicit invocation is not required. | |
Official Debian and Ubuntu images [automatically run `apt-get clean`](https://github.com/debuerreotype/debuerreotype/blob/c9542ab785e72696eb2908a6dbc9220abbabef39/scripts/debuerreotype-minimizing-config#L87-L109), so explicit invocation is not required. |
Description
I set a new URL for the source code because the old ones refer to the commit of the file, which is not used now, because Ubuntu for Docker is built from livecd scripts.
Related issues or tickets
Reviews