Check for Docker Desktop correctly #112
Merged
+3
−1
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
When the code was refactored to use a generic spawnDockerCommand function, the removal of 'docker' was missed so we were no longer running 'docker desktop version' correctly. We also need to use the onError function to ensure that the code is executed correctly in the event that the docker binary cannot be found. Signed-off-by: Remy Suen <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Problem Description
The Docker Desktop check is not being executed correctly. It's running
docker docker desktop versionnow.Proposed Solution
When the code was refactored to use a generic
spawnDockerCommandfunction, the removal of'docker'was missed so we were no longer runningdocker desktop versioncorrectly. We also need to use theonErrorfunction to ensure that the code is executed correctly in the event that the docker binary cannot be found.Proof of Work
Verified that the code is working in a debugger.