Skip to content

Label all maestro PRs w/ area-infrastructure #62146

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
May 28, 2025
Merged

Label all maestro PRs w/ area-infrastructure #62146

merged 1 commit into from
May 28, 2025

Conversation

wtgodbe
Copy link
Member

@wtgodbe wtgodbe commented May 28, 2025

This pull request includes a small change to the .github/policies/resourceManagement.yml file. The change removes the targetsBranch condition that specified the main branch as a target for applying the policy to apply the area-infrastructure label to dependency update PRs.

@wtgodbe wtgodbe requested a review from Copilot May 28, 2025 19:14
@wtgodbe wtgodbe requested a review from a team as a code owner May 28, 2025 19:14
@github-actions github-actions bot added the area-infrastructure Includes: MSBuild projects/targets, build scripts, CI, Installers and shared framework label May 28, 2025
Copy link
Contributor

@Copilot Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

This PR updates the resource management policy so that all dependency update PRs, regardless of branch, receive the area-infrastructure label.

  • Removed the targetsBranch: main condition from the policy
Comments suppressed due to low confidence (3)

.github/policies/resourceManagement.yml:242

  • After removing the targetsBranch entries, verify that the surrounding list indentation remains valid to avoid introducing an empty list item or YAML syntax errors.
then:

.github/policies/resourceManagement.yml:239

  • [nitpick] Consider adding a comment above this rule to note that it now applies to all branches, so future maintainers understand the broadened scope.
- titleContains:

.github/policies/resourceManagement.yml:240

  • Add or update automated tests to cover dependency update PRs on branches other than main to prevent regressions.
pattern: Source code updates

@wtgodbe
Copy link
Member Author

wtgodbe commented May 28, 2025

/ba-g Fabricbot update only

Copy link
Member

@danroth27 danroth27 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@wtgodbe wtgodbe merged commit 05c5d65 into main May 28, 2025
8 of 9 checks passed
@wtgodbe wtgodbe deleted the wtgodbe/AreaI branch May 28, 2025 19:15
@wtgodbe wtgodbe changed the title label all maestro PRs w/ area-infrastructure Label all maestro PRs w/ area-infrastructure May 28, 2025
@dotnet-policy-service dotnet-policy-service bot added this to the 10.0-preview6 milestone May 28, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area-infrastructure Includes: MSBuild projects/targets, build scripts, CI, Installers and shared framework
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants