Skip to content

2->8 core for copilot setup runner #62206

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Jun 2, 2025
Merged

2->8 core for copilot setup runner #62206

merged 1 commit into from
Jun 2, 2025

Conversation

danmoseley
Copy link
Member

Only takes about a minute off as we don't do much in the setup right now, but it's a minute, and would be more if we do more work.

experiments were: https://github.com/dotnet/aspnetcore/actions/workflows/copilot-setup-steps.yml

@danmoseley danmoseley requested a review from captainsafia June 2, 2025 03:31
@danmoseley danmoseley requested review from wtgodbe and a team as code owners June 2, 2025 03:31
@github-actions github-actions bot added the needs-area-label Used by the dotnet-issue-labeler to label those issues which couldn't be triaged automatically label Jun 2, 2025
@danmoseley danmoseley added area-infrastructure Includes: MSBuild projects/targets, build scripts, CI, Installers and shared framework and removed needs-area-label Used by the dotnet-issue-labeler to label those issues which couldn't be triaged automatically labels Jun 2, 2025
Copy link
Member

@captainsafia captainsafia left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

Does this influence the compute used by the agent during the workflow at all or is this strictly for setup?

@danmoseley
Copy link
Member Author

@captainsafia not sure, but if you look at this log
https://github.com/dotnet/runtime/actions/runs/15382436839/job/43275256420

you see that it starts with 'Runner name: '8-core-ubuntu-latest_c28ff075100e'' then continues both setup and its actual work in the same log -- so probably? but I assumed that multicore was less helpful during hte actual work process. it's usually calling CAPI or doing simple commands?

cc @Chuxel any idea

@danmoseley danmoseley enabled auto-merge (squash) June 2, 2025 15:40
@danmoseley
Copy link
Member Author

/ba-g not in build

@danmoseley danmoseley merged commit faf2696 into main Jun 2, 2025
7 of 8 checks passed
@danmoseley danmoseley deleted the speedupcopilotprebuild branch June 2, 2025 15:41
@dotnet-policy-service dotnet-policy-service bot added this to the 10.0-preview6 milestone Jun 2, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area-infrastructure Includes: MSBuild projects/targets, build scripts, CI, Installers and shared framework
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants