[MVC.Testing] Fix NullReferenceException #62231
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Fix `NullReferenceException` accessing `Services` in a web application using top-level programs. Fixes dotnet#62224.
github-actions
bot
added
the
area-mvc
dotnet-policy-service
bot
added
the
community-contribution
There was a problem hiding this comment.
Pull Request Overview
This PR fixes a NullReferenceException in WebApplicationFactory.Services by updating the service resolution logic and adding tests for minimal and real server scenarios.
- Removed an unused using directive in RealServerWithDynamicPortIntegrationTests.cs.
- Added integration tests for minimal-backed and real server scenarios.
- Updated the Services getter in WebApplicationFactory.cs to handle potential null values.
Reviewed Changes
Copilot reviewed 5 out of 5 changed files in this pull request and generated 1 comment.
Show a summary per file
| File | Description |
|---|---|
| src/Mvc/test/Mvc.FunctionalTests/RealServerWithDynamicPortIntegrationTests.cs | Removed an unused using directive. |
| src/Mvc/test/Mvc.FunctionalTests/RealServerUsingMinimalBackedIntegrationTests.cs | Added minimal-backed integration tests including service resolution. |
| src/Mvc/test/Mvc.FunctionalTests/RealServerBackedIntegrationTests.cs | Removed redundant base address assignment and added a test for resolving services. |
| src/Mvc/test/Mvc.FunctionalTests/KestrelBasedWebApplicationFactoryForMinimal.cs | Introduced a new web application factory utilizing a dynamically assigned port. |
| src/Mvc/Mvc.Testing/src/WebApplicationFactory.cs | Updated the Services getter to fallback to _host.Services when _webHost is null. |
captainsafia
reviewed
Jun 4, 2025
captainsafia
approved these changes
Jun 4, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix NullReferenceException from WebApplicationFactory.Services
Fix
NullReferenceExceptionfromWebApplicationFactory.Services.Description
Fix
NullReferenceExceptionaccessingServicesin a web application using top-level programs and add tests.Fixes #62224