Skip to content

Revert SDK update #62244

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 2 commits into from
Closed

Revert SDK update #62244

wants to merge 2 commits into from

Conversation

wtgodbe
Copy link
Member

@wtgodbe wtgodbe commented Jun 4, 2025

The last SDK update broke test discovery: #62223. We should hold off on taking any more updates until the underlying bug is fixed

@wtgodbe wtgodbe requested a review from a team as a code owner June 4, 2025 17:21
@wtgodbe wtgodbe requested a review from Copilot June 4, 2025 17:22
@github-actions github-actions bot added the area-infrastructure Includes: MSBuild projects/targets, build scripts, CI, Installers and shared framework label Jun 4, 2025
Copy link
Contributor

@Copilot Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

Reverts the .NET SDK version to avoid a known test discovery issue introduced in the previous preview release.

  • Downgrade SDK version from 10.0.100-preview.6.25272.112 back to 10.0.100-preview.4.25216.37
  • Aligns the dotnet tool version with the reverted SDK

@Youssef1313
Copy link
Member

Possible alternative: #62250, if it got green and worked.

@wtgodbe
Copy link
Member Author

wtgodbe commented Jun 4, 2025

Consistent test failure:

Templates.Mvc.Test.BlazorTemplateTest.BlazorWebTemplate_NoAuth(args: ["--empty"])

Project new blazor --no-restore --empty failed to publish. Exit code 1.
/datadisks/disk1/work/BD530A59/p/dotnet-cli/dotnet publish --no-restore -c Release /bl
StdErr:
StdOut: /datadisks/disk1/work/BD530A59/p/dotnet-cli/sdk/10.0.100-preview.5.25265.106/Sdks/Microsoft.NET.Sdk/targets/Microsoft.NET.RuntimeIdentifierInference.targets(326,5): message NETSDK1057: You are using a preview version of .NET. See: https://aka.ms/dotnet-support-policy [/datadisks/disk1/work/BD530A59/w/BA3B09E0/e/Templates/BaseFolder/AspNet.Cojb3nj5kx0f/AspNet.Cojb3nj5kx0f.csproj]
/datadisks/disk1/work/BD530A59/w/BA3B09E0/e/Templates/BaseFolder/AspNet.Cojb3nj5kx0f/Components/Routes.razor(1,75): error CS0234: The type or namespace name 'NotFound' does not exist in the namespace 'AspNet.Cojb3nj5kx0f.Components.Pages' (are you missing an assembly reference?) [/datadisks/disk1/work/BD530A59/w/BA3B09E0/e/Templates/BaseFolder/AspNet.Cojb3nj5kx0f/AspNet.Cojb3nj5kx0f.csproj]

@javiercn @ilonatommy could you take a look?

@wtgodbe
Copy link
Member Author

wtgodbe commented Jun 4, 2025

That's the not the only one, there's this too:

Templates.Test.BaselineTest.Template_Produces_The_Right_Set_Of_FilesAsync(arguments: "new blazor --empty", expectedFiles: ["appsettings.Development.json", "appsettings.json", "{ProjectName}.csproj", "Program.cs", "Components/App.razor", ···])

Expected file to exist, but it doesn't: Components/Pages/NotFound.razor

These probably would have been failing for a few days if they'd been running - I see the same in #62250 (that PR is preferable to this one, all else being equal)

@ilonatommy
Copy link
Member

@javiercn @ilonatommy could you take a look?

Thanks! Starting to check it out.

@ilonatommy
Copy link
Member

Closing as not needed after #62223 got in.

@ilonatommy ilonatommy closed this Jun 5, 2025
@dotnet-policy-service dotnet-policy-service bot added this to the 10.0-preview6 milestone Jun 5, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area-infrastructure Includes: MSBuild projects/targets, build scripts, CI, Installers and shared framework
Projects
None yet
Development

Successfully merging this pull request may close these issues.

7 participants