Skip to content

Add dotnet-trace to Debug ThreadPool Starvation #46251

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 11 commits into from
May 29, 2025

Conversation

verdie-g
Copy link
Contributor

@verdie-g verdie-g commented May 18, 2025

Summary

In .NET 9, a new event was added (dotnet/runtime#94737) to help diagnose thread pool starvation. It is documented in dotnet-trace #40852.

In this PR, I'm adding a section to Debug ThreadPool Starvation to show how to collect this event, and analyze it using both PerfView and a cross-platform tool that I made in Blazor.

cc @kouvel @noahfalk who helped implementing this event


Internal previews

📄 File 🔗 Preview link
docs/core/diagnostics/debug-threadpool-starvation.md Debug ThreadPool starvation

@verdie-g verdie-g requested review from tommcdon and a team as code owners May 18, 2025 21:22
@dotnetrepoman dotnetrepoman bot added this to the May 2025 milestone May 18, 2025
@dotnet-policy-service dotnet-policy-service bot added dotnet-fundamentals/svc community-contribution Indicates PR is created by someone from the .NET community. labels May 18, 2025
@tommcdon tommcdon requested a review from noahfalk May 19, 2025 00:50
Copy link
Member

@noahfalk noahfalk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for putting these docs together! I made some suggestions inline and probably the docs team (@gewarren or @CamSoper) will have suggestions as well.

@verdie-g verdie-g requested a review from noahfalk May 25, 2025 16:52
@verdie-g verdie-g requested a review from noahfalk May 27, 2025 21:45
@verdie-g verdie-g force-pushed the tp-starv-dotnet-trace branch from 0c63da1 to de9f376 Compare May 27, 2025 22:46
Copy link
Member

@noahfalk noahfalk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

Copy link
Contributor

@gewarren gewarren left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I left a few more suggestions, then I'll check the preview.

@verdie-g verdie-g requested a review from gewarren May 28, 2025 00:04
@gewarren
Copy link
Contributor

Some of the screenshots are too tiny to read, but you can make them clickable/enlargeable.

image

@verdie-g verdie-g requested a review from gewarren May 28, 2025 23:13
@gewarren gewarren merged commit 7b72268 into dotnet:main May 29, 2025
8 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
community-contribution Indicates PR is created by someone from the .NET community. dotnet-fundamentals/svc
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants