Skip to content

Conversation

@BrianGilbert
Copy link

No description provided.

@aaronbauman
Copy link

I'm getting an error when testing in version simplesamlphp/simplesamlphp:dev-simplesamlphp-2.1

Caused by: Exception: Could not resolve 'drupalauth:External': The class 'SimpleSAML\Module\drupalauth\Auth\Source\External' isn't a subclass of '\SimpleSAML\Auth\Source'.

Which is weird, because SimpleSAML\Module\drupalauth\Auth\Source\External is definitely a subclass of SimpleSAML\Auth\Source

stack trace:

SimpleSAML\Error\Error: UNHANDLEDEXCEPTION
Backtrace:
2 public/_include.php:28 (SimpleSAML_exception_handler)
1 vendor/symfony/error-handler/ErrorHandler.php:537 (Symfony\Component\ErrorHandler\ErrorHandler::handleException)
0 [builtin] (N/A)
Caused by: Exception: Could not resolve 'drupalauth:External': The class 'SimpleSAML\Module\drupalauth\Auth\Source\External' isn't a subclass of '\SimpleSAML\Auth\Source'.
Backtrace:
8 src/SimpleSAML/Module.php:459 (SimpleSAML\Module::resolveClass)
7 src/SimpleSAML/Auth/Source.php:313 (SimpleSAML\Auth\Source::parseAuthSource)
6 src/SimpleSAML/Auth/Source.php:356 (SimpleSAML\Auth\Source::getById)
5 src/SimpleSAML/Auth/Simple.php:62 (SimpleSAML\Auth\Simple::getAuthSource)
4 src/SimpleSAML/Auth/Simple.php:151 (SimpleSAML\Auth\Simple::login)
3 [builtin] (call_user_func_array)
2 src/SimpleSAML/HTTP/RunnableResponse.php:68 (SimpleSAML\HTTP\RunnableResponse::sendContent)
1 vendor/symfony/http-foundation/Response.php:423 (Symfony\Component\HttpFoundation\Response::send)
0 public/module.php:24 (N/A)
            

Sorry if this is the wrong place to report - lots of moving parts here.

@aaronbauman
Copy link

Update - renaming lib directory to src resolves this issue.

@jonbot
Copy link

jonbot commented Oct 2, 2023

Tested on our D10 site, and this worked great for us (when including @aaronbauman's PR above). Would love to see this get merged in so that the project supports Drupal 10!

Rename 'lib' directory to 'src' so that autodiscovery can find our classes
@sonarqubecloud
Copy link

sonarqubecloud bot commented Oct 6, 2023

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
No Duplication information No Duplication information

Dawnthorn added a commit to giant-rabbit/drupalauth4ssp that referenced this pull request Oct 19, 2023
Switching to a repository that has a PR for
simplesamlphp-module-drupalauth
(drupalauth/simplesamlphp-module-drupalauth#90)
that pulls in SimpleSAMLPHP 2.0 which we need because it has Twig 3
which matches what Drupal 10 is using.

Issue #62550
csingletwd added a commit to csingletwd/simplesamlphp-module-drupalauth that referenced this pull request Oct 23, 2023
csingletwd added a commit to csingletwd/simplesamlphp-module-drupalauth that referenced this pull request Oct 23, 2023
csingletwd added a commit to csingletwd/simplesamlphp-module-drupalauth that referenced this pull request Oct 23, 2023
csingletwd added a commit to csingletwd/simplesamlphp-module-drupalauth that referenced this pull request Oct 23, 2023
csingletwd added a commit to csingletwd/simplesamlphp-module-drupalauth that referenced this pull request Oct 23, 2023
@RoSk0 RoSk0 deleted the branch drupalauth:master November 7, 2023 21:20
@RoSk0 RoSk0 closed this Nov 7, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants