Skip to content

Conversation

@j4-m
Copy link

@j4-m j4-m commented Jan 30, 2024

No description provided.

@sonarqubecloud
Copy link

sonarqubecloud bot commented Feb 6, 2024

Quality Gate Passed Quality Gate passed

The SonarCloud Quality Gate passed, but some issues were introduced.

1 New issue
0 Security Hotspots
No data about Coverage
0.0% Duplication on New Code

See analysis details on SonarCloud

stesi561 added a commit to stesi561/simplesamlphp-module-drupalauth that referenced this pull request May 20, 2024
DrupalHelper.php has shifted location.
@stesi561
Copy link

I've ended up creating another PR as a reroll of this.

Note if you find yourself here - Because this patch updates the autoloader you need to get composer to update this. While it would seem that there should be someway to get composer to update vendor/composer/autoload_psr4.php after patching - I ended up installing from the github repo to get this to work.

@stesi561
Copy link

Also this patch requires PHP 8.x

@brooke-heaton
Copy link

Unfortunately it looks like the PR-99 patch isn't applying against version 2.7.

@stesi561
Copy link

I've rerolled this in pull/103

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants