Skip to content

[Feat] Add --create-issue character limit check #469

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 0 commits into from

Conversation

bombillazo
Copy link
Contributor

@bombillazo bombillazo commented May 28, 2023

Fixes #328

This change adds a limit to the message sent to the GitHub create issue URL to avoid URL too long errors.

If the diff contents exceed 300 characters (this was chosen arbitrarily), the diff contents are replaced with a comment message replacement, and the console outputs the complete PR diff contents and instructs the user to copy/paste the diff into the PR description manually.

@bombillazo bombillazo requested a review from ds300 June 1, 2023 14:52
@bombillazo
Copy link
Contributor Author

Hey @ds300 , did you see the updated code?

@bombillazo
Copy link
Contributor Author

@ds300 does this look ok?

@bombillazo
Copy link
Contributor Author

Hey @ds300 were you able to revise the updated code?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Using --create-issue result in bad request.
2 participants