Skip to content

fix(transport): merge default headers with custom headers (#2862) #2876

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

jerinthomascarmel
Copy link

@jerinthomascarmel jerinthomascarmel commented Jun 15, 2025

Fix header merge logic to preserve default headers when custom headers are provided

Changes:
Update header-merge logic to explicitly spread default headers and then apply opts.headers, ensuring defaults are preserved.

Closes: #2862

Testing:
Run npm test to ensure the new header-merge test passes.

Copy link

❌ Author of the following commits did not sign a Contributor Agreement:
1dc54bb

Please, read and sign the above mentioned agreement if you want to contribute to this project

@prodsecmachine
Copy link

prodsecmachine commented Jun 15, 2025

🎉 Snyk checks have passed. No issues have been found so far.

security/snyk check is complete. No issues have been found. (View Details)

license/snyk check is complete. No issues have been found. (View Details)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Custom headers erases all header defaults rather than merging the two
2 participants