-
Notifications
You must be signed in to change notification settings - Fork 25.3k
ES|QL sample documentation #129350
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
ES|QL sample documentation #129350
Conversation
Pinging @elastic/ml-core (Team:ML) |
0edaacb
to
83899fd
Compare
83899fd
to
1c813a0
Compare
docs/reference/query-languages/esql/_snippets/commands/layout/sample.md
Outdated
Show resolved
Hide resolved
…sample.md Co-authored-by: Liam Thompson <[email protected]>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good, but let's double check the tech preview markers - I think one is missing, see below.
// Hardcode the sample values to work around the limitations of the CSV tests in the | ||
// presence of randomness, and be able to specify an expected result for the docs. | ||
| STATS emp_no = COUNT() | ||
| EVAL emp_no = [10018, 10024, 10062, 10081] | ||
| MV_EXPAND emp_no |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Haha, this is beautiful. But I like that we're making sure the syntax is valid, even though the output is not related to the query that's in the docs!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yeah, I know. Within the system's current limitations, I don't see anything better than this...
## `SAMPLE` [esql-sample] | ||
|
||
```yaml {applies_to} | ||
stack: preview 9.1 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@alex-spies this is the correct way of marking versioning/lifecycle (preview/beta/GA) in the new docs
We haven't consolidated all the existing pages yet, (see #128576) but we should start using this on a go-forward basis
The docs build will render the preview pill and there will be more explicit tooltips soon too :)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It's much nicer because we're using structured metadata that doesn't require as much manual maintenance, because the docs build handles the output
Say this goes GA in 9.3, all we have to do is append a comma-separated version and the docs will be up-to-date and version-aware on the page without having to switch versions using different URLs:
eg
stack: preview 9.1, ga 9.3
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Oh, this is great. Thanks for the explanation!
No description provided.