Remove Generated Warnings #2442
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
To remove warnings as per esp8266#2183
We do not want to check state() nor getSize() if _client is NULL. Removed warnings as per esp8266#2183
Checked for usage within repository using `grep -rnw . -e "init_lists"`. No occurances (excepting this one) found, however, have kept as separate commit for exclusion is required. Removed warnings as per esp8266#2183
Current coverage is 27.80% (diff: 100%)@@ master #2442 diff @@
==========================================
Files 20 20
Lines 3625 3625
Methods 335 335
Messages 0 0
Branches 656 656
==========================================
Hits 1008 1008
Misses 2441 2441
Partials 176 176
|
|
What's the status here? |
|
Closing, as most warnings are already fixed in latest git. The only code modification I will do (in a clean PR) is the removal of init_lists, as it serves no purpose. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Updates to remove warnings I have come across in 2.3.0 builds. See issue #2183
I have split into 3 separate commits;