Skip to content

fix(rainmaker): Fix the 8MB partition scheme #11363

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

P-R-O-C-H-Y
Copy link
Member

Description of Change

This PR fixes the 8MB RainMaker partition scheme.

Tests scenarios

Compiled successfully with RainMaker Switch example.

Related links

https://esp32.com/viewtopic.php?t=45335

Copy link
Contributor

Messages
📖 🎉 Good Job! All checks are passing!

👋 Hello P-R-O-C-H-Y, we appreciate your contribution to this project!


📘 Please review the project's Contributions Guide for key guidelines on code, documentation, testing, and more.

🖊️ Please also make sure you have read and signed the Contributor License Agreement for this project.

Click to see more instructions ...


This automated output is generated by the PR linter DangerJS, which checks if your Pull Request meets the project's requirements and helps you fix potential issues.

DangerJS is triggered with each push event to a Pull Request and modify the contents of this comment.

Please consider the following:
- Danger mainly focuses on the PR structure and formatting and can't understand the meaning behind your code or changes.
- Danger is not a substitute for human code reviews; it's still important to request a code review from your colleagues.
- To manually retry these Danger checks, please navigate to the Actions tab and re-run last Danger workflow.

Review and merge process you can expect ...


We do welcome contributions in the form of bug reports, feature requests and pull requests.

1. An internal issue has been created for the PR, we assign it to the relevant engineer.
2. They review the PR and either approve it or ask you for changes or clarifications.
3. Once the GitHub PR is approved we do the final review, collect approvals from core owners and make sure all the automated tests are passing.
- At this point we may do some adjustments to the proposed change, or extend it by adding tests or documentation.
4. If the change is approved and passes the tests it is merged into the default branch.

Generated by 🚫 dangerJS against 6b33a71

@lucasssvaz lucasssvaz requested a review from Copilot May 14, 2025 07:33
Copy link
Contributor

@Copilot Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

This PR fixes the 8MB RainMaker partition scheme by adjusting OTA partition sizes and updating board configuration settings. Key changes include updating partition offsets/sizes in the CSV file and consistently revising the upload maximum sizes across multiple board definitions.

Reviewed Changes

Copilot reviewed 2 out of 2 changed files in this pull request and generated no comments.

File Description
tools/partitions/rainmaker_8MB.csv Updated ota_0 and ota_1 partition sizes to align with the 8MB scheme
boards.txt Adjusted upload.maximum_size values for rainmaker_8MB across various board configurations
Comments suppressed due to low confidence (2)

tools/partitions/rainmaker_8MB.csv:4

  • Ensure that the revised partition size (0x3EA000) for ota_0 is correctly aligned with the overall flash memory layout and compatible with OTA update routines.
+ota_0,     app,   ota_0,   0x10000,  0x3EA000,

boards.txt:1113

  • Verify that the updated upload maximum size value (4096000) properly reflects the new partition scheme and does not introduce boundary issues.
+esp32c3.menu.PartitionScheme.rainmaker_8MB.upload.maximum_size=4096000

@P-R-O-C-H-Y P-R-O-C-H-Y added Status: Pending Merge Pull Request is ready to be merged and removed Status: Review needed Issue or PR is awaiting review labels May 14, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Status: Pending Merge Pull Request is ready to be merged
Projects
Status: In Review
Development

Successfully merging this pull request may close these issues.

1 participant