-
Notifications
You must be signed in to change notification settings - Fork 7.6k
fix(rainmaker): Fix the 8MB partition scheme #11363
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: master
Are you sure you want to change the base?
Conversation
👋 Hello P-R-O-C-H-Y, we appreciate your contribution to this project! 📘 Please review the project's Contributions Guide for key guidelines on code, documentation, testing, and more. 🖊️ Please also make sure you have read and signed the Contributor License Agreement for this project. Click to see more instructions ...
Review and merge process you can expect ...
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Pull Request Overview
This PR fixes the 8MB RainMaker partition scheme by adjusting OTA partition sizes and updating board configuration settings. Key changes include updating partition offsets/sizes in the CSV file and consistently revising the upload maximum sizes across multiple board definitions.
Reviewed Changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated no comments.
File | Description |
---|---|
tools/partitions/rainmaker_8MB.csv | Updated ota_0 and ota_1 partition sizes to align with the 8MB scheme |
boards.txt | Adjusted upload.maximum_size values for rainmaker_8MB across various board configurations |
Comments suppressed due to low confidence (2)
tools/partitions/rainmaker_8MB.csv:4
- Ensure that the revised partition size (0x3EA000) for ota_0 is correctly aligned with the overall flash memory layout and compatible with OTA update routines.
+ota_0, app, ota_0, 0x10000, 0x3EA000,
boards.txt:1113
- Verify that the updated upload maximum size value (4096000) properly reflects the new partition scheme and does not introduce boundary issues.
+esp32c3.menu.PartitionScheme.rainmaker_8MB.upload.maximum_size=4096000
Description of Change
This PR fixes the 8MB RainMaker partition scheme.
Tests scenarios
Compiled successfully with RainMaker Switch example.
Related links
https://esp32.com/viewtopic.php?t=45335