Skip to content

Reflects change in esp_bt_gap_set_scan_mode in esp-idf #2640

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 3 commits into from

Conversation

pvint
Copy link
Contributor

@pvint pvint commented Apr 5, 2019

In espressif/esp-idf@5beb280 the function esp_bt_gap_set_scan_mode() was changed to split the parameter into two parameters (one for CONNECTABLE and one for DISCOVERABLE), resulting in the following error when compiling within esp-idf:

/home/pvint/Electronics/Starfish-idf/components/arduino/libraries/BluetoothSerial/src/BluetoothSerial.cpp: In function 'void esp_spp_cb(esp_spp_cb_event_t, esp_spp_cb_param_t*)':
/home/pvint/Electronics/Starfish-idf/components/arduino/libraries/BluetoothSerial/src/BluetoothSerial.cpp:161:34: error: 'ESP_BT_SCAN_MODE_CONNECTABLE' was not declared in this scope
         esp_bt_gap_set_scan_mode(ESP_BT_SCAN_MODE_CONNECTABLE, ESP_BT_GENERAL_DISCOVERABLE);
                                  ^

This PR addresses this change for BluetoothSerial.cpp

@me-no-dev
Copy link
Member

thanks will merge this when I update IDF in a couple of days :)

@justintconroy
Copy link

Still waiting...?

@CLAassistant
Copy link

CLAassistant commented Apr 28, 2021

CLA assistant check
All committers have signed the CLA.

@pvint
Copy link
Contributor Author

pvint commented Aug 10, 2021

2.5 years later and this is still an issue with a clean install. I'll try to update the PR soon, but it will likely be weeks at a minimum.

@me-no-dev me-no-dev closed this Dec 14, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants