Skip to content

#985 - Add Prerequisite to Exercises - Part 1 #1621

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 7 commits into from
Jan 15, 2022

Conversation

pertrai1
Copy link
Contributor

Adds prerequisites to the following exercises:

proverb
twelve-days
yacht
beer-song
resistor-color-trio

related to #985

@github-actions
Copy link
Contributor

Dear pertrai1

Thank you for contributing to the JavaScript track on Exercism! 💙
You will see some automated feedback below 🤖. It would be great if you can make sure your PR covers those points. This will save your reviewer some time and your change can be merged quicker.

  • ✍️ If your PR is not related to an existing issue (and is not self-explaining like a typo fix), please make sure the description explains why the change you made is necessary.

  • 🔤 If your PR fixes an easy to identify typo, if would be great if you could check for that typo in the whole repo. For example, if you found Unicdoe, use "replace all" in your editor (or command line magic) to fix it consistently.

Dear Reviewer/Maintainer

  • 📏 Make sure you set the appropriate x:size label for the PR. (This also works after merging, in case you forgot about it.)

  • 🔍 Don't be too nit-picky. If the PR is a clear improvement compared to the status quo, it should be approved as clear signal this is good to be merged even if the minor comments you might have are not addressed by the contributor. Further improvement ideas can be captured in issues (if important enough) and implemented via additional PRs.

  • 🤔 After reviewing the diff in the "Files changed" section, take a moment to think about whether there are changes missing from the diff. Does something need to be adjusted in other places so the code or content stays consistent?

Automated comment created by PR Commenter 🤖.

Copy link
Member

@junedev junedev left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Overall, the lists looked quite good already. I left some ideas what I would change.

config.json Outdated
"prerequisites": [],
"prerequisites": [
"arrays",
"array-transformations",
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can you explain why you think array-transformation is needed here? E.g. this solution does not use it but looks very reasonable: https://exercism.org/tracks/javascript/exercises/twelve-days/solutions/Chinmay

Also if you use array transformations, then you don't need for loops anymore here. So either one should be removed. (My vote is with removing array-transformations, we could still use it in "practices" later in case we think this is a good exercise for that.)

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ok thanks. I did not know if it would be best to list all potential prerequisites.

In regards to transformations, I went based on the proof to determine this being a prerequisite.

Copy link
Member

@junedev junedev Jan 15, 2022

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

To clarify: "Prerequisites" means that a student cannot work on this exercise until they unlocked those concepts. Because of that we do not want to list all potential prerequisites but instead answer the question "what is a minimal set of concepts someone needs to know to write a reasonable solution for this exercise".

@junedev junedev added the x:size/small Small amount of work label Jan 15, 2022
@pertrai1 pertrai1 requested a review from junedev January 15, 2022 16:03
@junedev junedev merged commit 8c93305 into exercism:main Jan 15, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
x:size/small Small amount of work
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants