-
-
Notifications
You must be signed in to change notification settings - Fork 632
#985 - Add Prerequisite to Exercises - Part 1 #1621
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Dear pertrai1Thank you for contributing to the JavaScript track on Exercism! 💙
Dear Reviewer/Maintainer
Automated comment created by PR Commenter 🤖. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Overall, the lists looked quite good already. I left some ideas what I would change.
config.json
Outdated
"prerequisites": [], | ||
"prerequisites": [ | ||
"arrays", | ||
"array-transformations", |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Can you explain why you think array-transformation is needed here? E.g. this solution does not use it but looks very reasonable: https://exercism.org/tracks/javascript/exercises/twelve-days/solutions/Chinmay
Also if you use array transformations, then you don't need for loops anymore here. So either one should be removed. (My vote is with removing array-transformations, we could still use it in "practices" later in case we think this is a good exercise for that.)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Ok thanks. I did not know if it would be best to list all potential prerequisites.
In regards to transformations, I went based on the proof to determine this being a prerequisite.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
To clarify: "Prerequisites" means that a student cannot work on this exercise until they unlocked those concepts. Because of that we do not want to list all potential prerequisites but instead answer the question "what is a minimal set of concepts someone needs to know to write a reasonable solution for this exercise".
Adds prerequisites to the following exercises:
related to #985