Skip to content

Code Quality: Refactored command titles and descritption for clarity and consistency #17146

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 13 commits into from
Closed

Code Quality: Refactored command titles and descritption for clarity and consistency #17146

Changes from 1 commit
Commits
Show all changes
13 commits
Select commit Hold shift + click to select a range
c59a6a2
Update Resources.resw
Lukiluc29 May 20, 2025
27158c0
Changes of small details
Lukiluc29 May 20, 2025
f69d8ae
Same
Lukiluc29 May 20, 2025
8b6ddda
Add string
Lukiluc29 May 20, 2025
6c84a29
Strings
Lukiluc29 May 20, 2025
b18338f
Copilot suggestion
Lukiluc29 May 21, 2025
6815ede
Correction of a micro error
Lukiluc29 May 21, 2025
e98c33f
First changes
Lukiluc29 May 25, 2025
074ceb8
Suggestions
Lukiluc29 May 29, 2025
ea5921d
Other requested changes
Lukiluc29 May 29, 2025
73ed7aa
Small changes
Lukiluc29 Jun 6, 2025
15e6634
Error when changing
Lukiluc29 Jun 6, 2025
1561f94
More changes...
Lukiluc29 Jun 7, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
More changes...
  • Loading branch information
@Lukiluc29
Lukiluc29 committed Jun 7, 2025
commit 1561f9436ce49ded9acb3ccbe7fff7e9695ffadc
6 changes: 3 additions & 3 deletions src/Files.App/Strings/en-US/Resources.resw
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2229,7 +2229,7 @@
<value>Settings</value>
</data>
<data name="DoubleClickBlankSpaceToGoUp" xml:space="preserve">
<value>Double-click a blank space to navigate one level up the folder tree</value>
<value>Double-click blank space to navigate one level up the folder tree</value>
</data>
<data name="ViewMore" xml:space="preserve">
<value>View more</value>
Expand Down Expand Up @@ -2703,10 +2703,10 @@
<value>Open a new tab in the same window</value>
</data>
<data name="NavigateBackDescription" xml:space="preserve">
<value>Navigate to the previous folder</value>
<value>Navigate to the previous location</value>
</data>
<data name="NavigateForwardDescription" xml:space="preserve">
<value>Navigate to the next folder</value>
<value>Navigate to the next location</value>
</data>
<data name="NavigateUpDescription" xml:space="preserve">
<value>Navigate one level up in the folder tree</value>
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@Jay-o-Way Navigate one level up in the folder tree vs Navigate one level up the folder tree?

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hm, tricky one, mostly looking at "navigate". That one is often used for websites and such. Simply saying "move one level up" sounds smoother. As for "in" or not, i would personally leave it out. Thinking of phrases like "move up a ladder".

In case of doubt, search MS Learn.

https://learn.microsoft.com/en-us/style-guide/a-z-word-list-term-collections/f/folder-folder-icon
https://learn.microsoft.com/en-us/style-guide/procedures-instructions/describing-interactions-with-ui

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We've been using the term 'navigate' for quite some time, so I'm not concerned about that part.

Expand Down