Skip to content

feat: utilise string localisations #1248

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 9 commits into
base: main
Choose a base branch
from

Conversation

russellwheatley
Copy link
Member

@russellwheatley russellwheatley commented Apr 30, 2025

PR contains string localization implementation.

A couple of things to note;

  • There are no strings as far as I can see for verifying email so I left VerifyEmailView as it is, until the below question is resolved.
  • I haven't touched the Facebook, Phone or Google provider Swift package until the question below has been resolved.

Questions

  1. Should we keep all strings within the core package? If they need to be within their own Swift package (e.g. Facebook strings in Facebook Swift package), then this would require some refactoring to the internal implementation so we can make use of each packages Bundle.module which contains the strings.
  2. Should we add strings to the string catalog for missing strings such as verifying email?

@russellwheatley russellwheatley marked this pull request as ready for review April 30, 2025 13:15
@morganchen12
Copy link
Contributor

Should we want to keep all strings within the core package? If they need to be within their own Swift package (e.g. Facebook strings in Facebook Swift package), then this would require some refactoring to the internal implementation so we can make use of each packages Bundle.module which contains the strings.

Though it's a big of an abstraction-break I think we should given the localization bundle override is in the core package and strings themselves aren't stateful and have no dependencies. Overall I expect the strings required for 3P auth providers to be minimal since those dependencies (GoogleSignIn etc) also do their own localization.

Should we add strings to the string catalog for missing strings such as verifying email?

Yes, if you can add placeholders that'd be great. I'll fill them in with internal l10n resources async and they shouldn't be a blocker for this project. In the meantime Xcode will display whatever you use as a placeholder.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants