question: how to make Views concrete? (i.e not use Any View) #1249
+56
−24
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I think we should just make the button views |
peterfriese
reviewed
May 1, 2025
| associatedtype ButtonType: View | ||
| @MainActor var authButton: ButtonType { get } | ||
| var id: String { get } | ||
| @MainActor func authButton() -> AnyView |
There was a problem hiding this comment.
Did you try returning some View? You might need to annotate the function with @ViewBuilder
There was a problem hiding this comment.
cannot have some View as return type on protocol apparently. Get Xcode compiler error: 'some' type cannot be the return type of a protocol requirement; did you mean to add an associated type?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I cannot find a way to make it work where the Buttons are not type erased.
We have types unknown to core auth package and we're trying to render unknown button types in core auth package. How can we render without using type erasure?
If there is a clever way of doing this, I would love to know.