GCIP BYO-CIAM Initialize Auth Changes #8995
Merged
+126
−4
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mansisampat
requested review from
lisajian,
Xiaoshouzi-gh,
sam-gc,
pashanka,
NhienLam and
a team
as code owners
|
Vertex AI Mock Responses Check
|
Size Report 1Affected Products
Test Logs |
Size Analysis Report 1Affected Products
Test Logs |
mansisampat
force-pushed
the
sammansi-gcip-byociam-web
branch
from
af47101 to
2ff7bfc
Compare
pashanka
requested changes
May 5, 2025
common/api-review/auth.api.md
Outdated
Comment on lines
801
to
802
| location?: string; | ||
| tenantId?: string; |
There was a problem hiding this comment.
Shouldn't these be mandatory fields inside tenantConfig?
There was a problem hiding this comment.
Correct. Changed here and all other places.
Comment on lines
1264
to
1265
| * The {@link TenantConfig} to use. This field is optional and required | ||
| * if Regional Auth Instance needs to be configured. The Auth instance depends |
There was a problem hiding this comment.
We can rephrase it as below, wdyt?
This dependency is only required if you want to use regional auth which works with {@link DefaultConfig.REGIONAL_API_HOST} endpoint. It should not be set otherwise.
| /** | ||
| * Which location to use. | ||
| */ | ||
| location?: string; |
There was a problem hiding this comment.
Same as above, shouldn't this be mandatory?
pashanka
approved these changes
May 8, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Discussion
Implement BYO-CIAM Initialize regional auth changes.
Testing
apiHostusing Firebase Auth Demo App - https://screenshot.googleplex.com/8mvvxSaC2dBxe3UAPI Changes
Implemented Initialize Auth changes as per the API Proposal doc - go/gcip-byociam-web-api-proposal