feat(remote_config): Migrate firebase_remote_config iOS and Android to Pigeon #17304
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This commit migrates the native communication layer for the firebase_remote_config plugin on iOS and Android from MethodChannel to Pigeon.
Work Done:
messages.pigeon
in the platform interface package, defining the Host API (FirebaseRemoteConfigHostApi
) and data structures based on the existing MethodChannel methods.messages.pigeon
with@ConfigurePigeon
to specify output paths for Dart, Swift, and Kotlin in the mainfirebase_remote_config
package. (Note: Actual generation was not performed due to tool limitations).FLTFirebaseRemoteConfigPlugin.m
(Objective-C) to implement theFirebaseRemoteConfigHostApi
protocol generated by Pigeon. Replaced MethodChannel handling with Pigeon API calls, adapting helper methods and updating plugin registration. EventChannel logic foronConfigUpdated
remains.FirebaseRemoteConfigPlugin.java
to implement theFirebaseRemoteConfigHostApi
interface generated by Pigeon. Replaced MethodChannel handling, adapted helper methods, converted data types, and updated plugin registration to use Pigeon. EventChannel logic remains.Next Steps (Incomplete):
The Dart side implementation is pending:
PigeonFirebaseRemoteConfig
) extendingFirebaseRemoteConfigPlatform
in thefirebase_remote_config_platform_interface
package. This class should use the generated Dart Pigeon client (messages.g.dart
) to call the native Host APIs.firebase_remote_config
's main Dart code to use the newPigeonFirebaseRemoteConfig
implementation.This includes the completed native iOS and Android migrations. Further work is needed on the Dart side to fully utilize the Pigeon implementation.
Description
Replace this paragraph with a description of what this PR is doing. If you're modifying existing behavior, describe the existing behavior, how this PR is changing it, and what motivated the change.
Related Issues
Replace this paragraph with a list of issues related to this PR from the issue database. Indicate, which of these issues are resolved or fixed by this PR. Note that you'll have to prefix the issue numbers with flutter/flutter#.
Checklist
Before you create this PR confirm that it meets all requirements listed below by checking the relevant checkboxes (
[x]
).This will ensure a smooth and quick review process. Updating the
pubspec.yaml
and changelogs is not required.///
).melos run analyze
) does not report any problems on my PR.Breaking Change
Does your PR require plugin users to manually update their apps to accommodate your change?