Skip to content

Commit c40677a

Browse files
gkalpakkara
authored andcommitted
ci: fix and re-enable payload size checks for integration tests (angular#26869)
See angular#22810, angular#23376 and angular#23515 for more context. Fixes angular#23376 Closes angular#23515 PR Close angular#26869
1 parent d4b46e2 commit c40677a

File tree

2 files changed

+12
-12
lines changed

2 files changed

+12
-12
lines changed

integration/_payload-limits.json

Lines changed: 3 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -3,18 +3,17 @@
33
"master": {
44
"uncompressed": {
55
"runtime": 1110,
6-
"main": 151765,
7-
"polyfills": 59462
6+
"main": 160134,
7+
"polyfills": 59620
88
}
99
}
1010
},
1111
"hello_world__closure": {
1212
"master": {
1313
"uncompressed": {
1414
"bundle": "TODO(i): temporarily increase the payload size limit from 105779 - this is due to a closure issue related to ESM reexports that still needs to be investigated",
15-
"bundle": 178101
15+
"bundle": 177585
1616
}
1717
}
1818
}
1919
}
20-

integration/run_tests.sh

Lines changed: 9 additions & 8 deletions
Original file line numberDiff line numberDiff line change
@@ -15,7 +15,7 @@ if $CI; then
1515
# We don't install this by default because it contains some broken Bazel setup
1616
# and also it's a very big dependency that we never use except when publishing
1717
# payload sizes on CI.
18-
yarn add --silent -D firebase-tools@3.12.0
18+
yarn add --silent -D firebase-tools@5.1.1
1919
source ${basedir}/scripts/ci/payload-size.sh
2020

2121
# NB: we don't run build-packages-dist.sh because we expect that it was done
@@ -47,20 +47,21 @@ for testDir in $(ls | grep -v node_modules) ; do
4747

4848
yarn install --cache-folder ../$cache
4949
yarn test || exit 1
50+
5051
# Track payload size for cli-hello-world and hello_world__closure and the render3 tests
51-
if [[ $testDir == cli-hello-world ]] || [[ $testDir == hello_world__closure ]]; then
52+
if $CI && ([[ $testDir == cli-hello-world ]] || [[ $testDir == hello_world__closure ]]); then
5253
if [[ $testDir == cli-hello-world ]]; then
5354
yarn build
5455
fi
55-
#if $CI; then
56-
# trackPayloadSize "$testDir" "dist/*.js" true false "${basedir}/integration/_payload-limits.json"
57-
#fi
56+
57+
trackPayloadSize "$testDir" "dist/*.js" true false "${basedir}/integration/_payload-limits.json"
5858
fi
59+
5960
# remove the temporary node modules directory to keep the source folder clean.
6061
rm -rf node_modules
6162
)
6263
done
6364

64-
#if $CI; then
65-
# trackPayloadSize "umd" "../dist/packages-dist/*/bundles/*.umd.min.js" false false
66-
#fi
65+
if $CI; then
66+
trackPayloadSize "umd" "../dist/packages-dist/*/bundles/*.umd.min.js" false false
67+
fi

0 commit comments

Comments
 (0)