Skip to content

Conversation

@gkalpak
Copy link
Member

@gkalpak gkalpak commented Oct 31, 2018

PR Checklist

PR Type

  • CI related changes

What is the current behavior?

  • Size checking/tracking is disabled for integration tests.
  • Integration test logs are very verbose.
  • Integration tests for elements are flaky on CI.

What is the new behavior?

  • Size checking/tracking is enabled for integration tests.
  • Integration test logs are less verbose.
  • Integration tests for elements are less flaky on CI.

Does this PR introduce a breaking change?

  • Yes
  • No

Other information

Fixes #23376.
Closes #23515.

@gkalpak gkalpak changed the title Ci integration fixes ci: integration checks fixes/improvements Oct 31, 2018
@gkalpak gkalpak added area: build & ci Related the build and CI infrastructure of the project action: review The PR is still awaiting reviews from at least one requested reviewer target: patch This PR is targeted for the next patch release labels Oct 31, 2018
@ngbot ngbot bot added this to the needsTriage milestone Oct 31, 2018
@gkalpak gkalpak force-pushed the ci-integration-fixes branch 2 times, most recently from c86cc0f to 374027d Compare October 31, 2018 16:12
@gkalpak gkalpak requested a review from IgorMinar October 31, 2018 20:10
@gkalpak gkalpak force-pushed the ci-integration-fixes branch 3 times, most recently from 235b5dc to db69077 Compare October 31, 2018 20:36
@gkalpak gkalpak force-pushed the ci-integration-fixes branch from db69077 to 4ad4acd Compare October 31, 2018 21:34
The build progress logs accounted for ~80% of the total log size, which
makes it harder to get to the interesting lines, such as error messages.

Used suggestion from [here][1].

[1]: angular/angular-cli#11412 (comment)
Since 8fc4ae5, the jobs that need Xvfb use `*-browser` CircleCI docker
image flavors (e.g. `circleci/node:10.12-browsers`), which automatically
start Xvfb.
@gkalpak gkalpak force-pushed the ci-integration-fixes branch from 4ad4acd to d17e8e2 Compare October 31, 2018 23:00
@IgorMinar IgorMinar added action: merge The PR is ready for merge by the caretaker and removed action: review The PR is still awaiting reviews from at least one requested reviewer labels Nov 2, 2018
@kara kara closed this in 53bae68 Nov 2, 2018
kara pushed a commit that referenced this pull request Nov 2, 2018
kara pushed a commit that referenced this pull request Nov 2, 2018
kara pushed a commit that referenced this pull request Nov 2, 2018
The build progress logs accounted for ~80% of the total log size, which
makes it harder to get to the interesting lines, such as error messages.

Used suggestion from [here][1].

[1]: angular/angular-cli#11412 (comment)

PR Close #26869
kara pushed a commit that referenced this pull request Nov 2, 2018
Since 8fc4ae5, the jobs that need Xvfb use `*-browser` CircleCI docker
image flavors (e.g. `circleci/node:10.12-browsers`), which automatically
start Xvfb.

PR Close #26869
kara pushed a commit that referenced this pull request Nov 2, 2018
kara pushed a commit that referenced this pull request Nov 2, 2018
kara pushed a commit that referenced this pull request Nov 2, 2018
kara pushed a commit that referenced this pull request Nov 2, 2018
The build progress logs accounted for ~80% of the total log size, which
makes it harder to get to the interesting lines, such as error messages.

Used suggestion from [here][1].

[1]: angular/angular-cli#11412 (comment)

PR Close #26869
kara pushed a commit that referenced this pull request Nov 2, 2018
Since 8fc4ae5, the jobs that need Xvfb use `*-browser` CircleCI docker
image flavors (e.g. `circleci/node:10.12-browsers`), which automatically
start Xvfb.

PR Close #26869
@gkalpak gkalpak deleted the ci-integration-fixes branch November 2, 2018 20:53
gkalpak added a commit to gkalpak/angular that referenced this pull request Jan 4, 2019
The build and test progress logs make the CI log output so long that it
can't be displayed in the UI and one has to download and view the file
locally instead. This makes it harder to get to the interesting lines,
such as error messages.

Similar to angular#26869, but for the `bazel-schematics` integration project.
kara pushed a commit that referenced this pull request Jan 4, 2019
The build and test progress logs make the CI log output so long that it
can't be displayed in the UI and one has to download and view the file
locally instead. This makes it harder to get to the interesting lines,
such as error messages.

Similar to #26869, but for the `bazel-schematics` integration project.

PR Close #27934
kara pushed a commit that referenced this pull request Jan 4, 2019
The build and test progress logs make the CI log output so long that it
can't be displayed in the UI and one has to download and view the file
locally instead. This makes it harder to get to the interesting lines,
such as error messages.

Similar to #26869, but for the `bazel-schematics` integration project.

PR Close #27934
@angular-automatic-lock-bot
Copy link

This issue has been automatically locked due to inactivity.
Please file a new issue if you are encountering a similar or related problem.

Read more about our automatic conversation locking policy.

This action has been performed automatically by a bot.

@angular-automatic-lock-bot angular-automatic-lock-bot bot locked and limited conversation to collaborators Sep 14, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

action: merge The PR is ready for merge by the caretaker area: build & ci Related the build and CI infrastructure of the project cla: yes target: patch This PR is targeted for the next patch release

Projects

None yet

Development

Successfully merging this pull request may close these issues.

re-enable size tracking in integration tests

3 participants