-
Notifications
You must be signed in to change notification settings - Fork 26.7k
ci: integration checks fixes/improvements #26869
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Closed
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
c86cc0f to
374027d
Compare
235b5dc to
db69077
Compare
See angular#22810, angular#23376 and angular#23515 for more context. Fixes angular#23376 Closes angular#23515
db69077 to
4ad4acd
Compare
The build progress logs accounted for ~80% of the total log size, which makes it harder to get to the interesting lines, such as error messages. Used suggestion from [here][1]. [1]: angular/angular-cli#11412 (comment)
Since 8fc4ae5, the jobs that need Xvfb use `*-browser` CircleCI docker image flavors (e.g. `circleci/node:10.12-browsers`), which automatically start Xvfb.
4ad4acd to
d17e8e2
Compare
IgorMinar
approved these changes
Nov 2, 2018
kara
pushed a commit
that referenced
this pull request
Nov 2, 2018
kara
pushed a commit
that referenced
this pull request
Nov 2, 2018
kara
pushed a commit
that referenced
this pull request
Nov 2, 2018
The build progress logs accounted for ~80% of the total log size, which makes it harder to get to the interesting lines, such as error messages. Used suggestion from [here][1]. [1]: angular/angular-cli#11412 (comment) PR Close #26869
kara
pushed a commit
that referenced
this pull request
Nov 2, 2018
kara
pushed a commit
that referenced
this pull request
Nov 2, 2018
kara
pushed a commit
that referenced
this pull request
Nov 2, 2018
kara
pushed a commit
that referenced
this pull request
Nov 2, 2018
The build progress logs accounted for ~80% of the total log size, which makes it harder to get to the interesting lines, such as error messages. Used suggestion from [here][1]. [1]: angular/angular-cli#11412 (comment) PR Close #26869
gkalpak
added a commit
to gkalpak/angular
that referenced
this pull request
Jan 4, 2019
The build and test progress logs make the CI log output so long that it can't be displayed in the UI and one has to download and view the file locally instead. This makes it harder to get to the interesting lines, such as error messages. Similar to angular#26869, but for the `bazel-schematics` integration project.
kara
pushed a commit
that referenced
this pull request
Jan 4, 2019
The build and test progress logs make the CI log output so long that it can't be displayed in the UI and one has to download and view the file locally instead. This makes it harder to get to the interesting lines, such as error messages. Similar to #26869, but for the `bazel-schematics` integration project. PR Close #27934
kara
pushed a commit
that referenced
this pull request
Jan 4, 2019
The build and test progress logs make the CI log output so long that it can't be displayed in the UI and one has to download and view the file locally instead. This makes it harder to get to the interesting lines, such as error messages. Similar to #26869, but for the `bazel-schematics` integration project. PR Close #27934
|
This issue has been automatically locked due to inactivity. Read more about our automatic conversation locking policy. This action has been performed automatically by a bot. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Labels
action: merge
The PR is ready for merge by the caretaker
area: build & ci
Related the build and CI infrastructure of the project
cla: yes
target: patch
This PR is targeted for the next patch release
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR Checklist
Tests for the changes have been added (for bug fixes / features)Docs have been added / updated (for bug fixes / features)PR Type
What is the current behavior?
elementsare flaky on CI.What is the new behavior?
elementsare less flaky on CI.Does this PR introduce a breaking change?
Other information
Fixes #23376.
Closes #23515.