chore(eslint): Add eslint-plugin-regexp rule
#18053
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
![cursor[bot]](https://avatars.githubusercontent.com/in/1210556?s=60&v=4){kind=small}
| // Note: CodeQL complains that this regex potentially has n^2 runtime. This likely won't affect realistic files. | ||
| new RegExp('^(?:\\s*|/\\*(?:.|\\r|\\n)*?\\*/|//.*[\\n\\r])*(?:"[^"]*";?|\'[^\']*\';?)?'); | ||
| // eslint-disable-next-line @sentry-internal/sdk/no-regexp-constructor,prefer-regex-literals | ||
| new RegExp('^(?:\\s|/\\*(?:.|[\\r\\n])*?\\*/|//.*[\\n\\r])*(?:"[^"]*";?|\'[^\']*\';?)?'); |
There was a problem hiding this comment.
Bug: Regex Pattern Error: Incorrectly Handles Whitespace
The regex pattern incorrectly removed the * quantifier from \s*. The original pattern ^\s* (zero or more whitespace) was changed to ^\s (exactly one whitespace), which fundamentally changes the regex semantics. The pattern should be ^(?:\s|/\*(?:.|[\r\n])*?\*\/|//.*[\n\r])* not ^(?:\\s|/\*(?:.|[\r\n])*?\*\/|//.*[\n\r])* to maintain backward compatibility. This breaks the directive-matching logic that needs to handle cases with no leading whitespace.
size-limit report 📦
|
node-overhead report 🧳Note: This is a synthetic benchmark with a minimal express app and does not necessarily reflect the real-world performance impact in an application.
|
|
Closes in favor of separating this into two PRs, which apply those rules once only for |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The problem with polynomial regular expressions was mentioned in a couple of comments already:
dirnameandbasenameshould handle Windows paths #8737 (comment)This ESLint package includes a rule which checks for polynomial expressions. Beside that it also adds some performance improvements like using Non-Capturing groups in case the groups are not used. Or also using
/dinstead of0-9Review Notes
--fixWhen making manual changes, I tested the regex on https://regex101.com/ and although I don't have scientific benchmarks, I saw a huge improvement (steps and time reduced by half) in the performance note.