Skip to content

opencl: preliminary support for Q4_0 mul_mat_id using matvec #14003

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Jun 10, 2025

Conversation

lhez
Copy link
Contributor

@lhez lhez commented Jun 4, 2025

This PR adds initial support for Q4_0 mul_mat_id using matvec. Optimized variants will be added as soon as they are done.

@github-actions github-actions bot added the ggml changes relating to the ggml tensor library for machine learning label Jun 4, 2025
@lhez lhez marked this pull request as ready for review June 4, 2025 20:35
Copy link
Collaborator

@max-krasnyansky max-krasnyansky left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good.
Did a quick test with olmoe-1b-7b-instruct-q4_0 and it's working as expected.

@max-krasnyansky
Copy link
Collaborator

Test failures are unrelated. Filed #14112 to track.

@max-krasnyansky max-krasnyansky merged commit 4c763c8 into ggml-org:master Jun 10, 2025
44 of 47 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
ggml changes relating to the ggml tensor library for machine learning
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants