Skip to content

ggml-cpu: fix uncaught underscore terminators for s390x #14023

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged

Conversation

taronaeo
Copy link
Contributor

@taronaeo taronaeo commented Jun 5, 2025

This pull request fixes unterminated underscores with __attribute__ in the s390x codebase.

Verification

To ensure that this patch did not break anything, the patch has been tested on the following models:

  1. Tested IBM Granite 3.1 (F16)

Note

Tests were conducted on an IBM z15 Mainframe with 16 IFLs (cores) and 160 GB Memory on an LPAR.

@github-actions github-actions bot added the ggml changes relating to the ggml tensor library for machine learning label Jun 5, 2025
@ericcurtin ericcurtin requested a review from Copilot June 18, 2025 17:06
@ericcurtin ericcurtin merged commit 6231c5c into ggml-org:master Jun 18, 2025
45 checks passed
Copy link

@Copilot Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

This PR fixes unterminated __attribute__ usages in S390x vector typedefs and aligns spacing for consistency.

  • Adds missing underscores around __attribute__((vector_size(16))) for double64x2_t and long64x2_t.
  • Adjusts whitespace in typedef declarations to match surrounding lines.
Comments suppressed due to low confidence (2)

ggml/src/ggml-cpu/ggml-cpu-impl.h:386

  • [nitpick] Consider adding an extra space before __attribute__ to align with other typedefs (e.g., two spaces) for consistent formatting.
typedef double double64x2_t __attribute__((vector_size(16)));

ggml/src/ggml-cpu/ggml-cpu-impl.h:388

  • [nitpick] The spacing between signed and long appears irregular; using single spaces and aligning with other lines could improve readability.
typedef signed   long long long64x2_t  __attribute__((vector_size(16)));

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
ggml changes relating to the ggml tensor library for machine learning
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants